Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to tailwind 1.x #435

Merged
merged 6 commits into from
Dec 12, 2019

Conversation

psbanka
Copy link
Contributor

@psbanka psbanka commented Dec 12, 2019

According to this comment, we need to upgrade ember-cli-addon-docs to tailwind v1.0 in order to take advantage of Tailwind's configuration directive which will allow us to turn off the preflight base styles by adding a configuration option of

corePlugins: {
  container: false,
  preflight: false
}

to address the core issue found in #178

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @samselikoff any concerns with this?

@samselikoff
Copy link
Contributor

Nice work Peter!

I think this still doesn't allow users to disable base styles yet right? That will be another feature?

@psbanka
Copy link
Contributor Author

psbanka commented Dec 12, 2019

That's right @samselikoff — I'm working on a follow-up PR right now to make the inclusion of the presets configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants