Upgrade ember-code-snippet to v3.0.0 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josemarluedke does this change the user facing API at all? |
|
Nope, no changes for addon-docs consumers. |
RobbieTheWagner
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
Nope, no changes for addon-docs consumers.
With that in mind, this looks good to me!
@samselikoff any concerns?
|
Wow, thanks so much for doing this @josemarluedke ! Been meaning to work on this forever. Looks like there are some failures in 2.12/2.18 🤔 |
josemarluedke
force-pushed
the
jl-upgrade-ember-code-snippet
branch
from
001a46d
to
142df07
Compare
|
@samselikoff tests are passing now. The let helper is not available in ember v2.x. |
|
Thanks man, nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a major version bump with some breaking changes: https://github.com/ef4/ember-code-snippet/blob/master/CHANGELOG.md#300
The notable change here is that they don't supply syntax highlight component out of the box anymore. We had highlight.js already, so it was just a matter of wiring everything together.
Note on the minimal style changes, I was looking at MirageJS docs site, and copied some changes from them as IMO looks a bit better.
cc/ @samselikoff @rwwagner90