Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
locks committed Jun 28, 2019
1 parent 035dcd9 commit 1195b73
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions guides/release/routing/defining-your-routes.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ routes, using the name that you provided to the `route` method.
</nav>
```

The `<LinkTo>` component will also add an `active` class to the link that
The `<LinkTo>` component will also add an `active` CSS class to the link that
points to the currently active route.

Multi-word route names are conventionally dasherized, such as:
Expand All @@ -76,7 +76,7 @@ Router.map(function() {

will still by default use the `blog-post.js` route handler and the
`blog-post.hbs` template, but will be referred to as `blog_post` in any
`<LinkTo>`.
`<LinkTo>` component.

## Nested Routes

Expand Down
2 changes: 1 addition & 1 deletion guides/release/routing/query-params.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ With this code, we have established the following behaviors:
full router transition (i.e. it won't call `model` hooks and
`setupController`, etc.); it will only update the URL.

### LinkTo component
### `LinkTo` component

The `LinkTo` component supports specifying query params using the
`query-params` subexpression helper.
Expand Down
4 changes: 2 additions & 2 deletions guides/release/testing/testing-components.md
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ export default Component.extend({

```handlebars {data-filename="app/templates/components/comment-form.hbs"}
<form {{action "submitComment" on="submit"}}>
<label>Comment:</label>
<Textarea @value={{this.comment}} />
<label for="comment">Comment:</label>
<Textarea @id="comment" @value={{this.comment}} />
<input class="comment-input" type="submit" value="Submit"/>
</form>
Expand Down

0 comments on commit 1195b73

Please sign in to comment.