Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCTANE] do some CSS hacks to hide the edit pencil and the search bar #611

Closed
jenweber opened this issue Mar 15, 2019 · 1 comment
Closed

[OCTANE] do some CSS hacks to hide the edit pencil and the search bar #611

jenweber opened this issue Mar 15, 2019 · 1 comment
Labels
help wanted Extra attention is needed Octane time-sensitive It is important that this task be finished very quickly

Comments

@jenweber
Copy link
Contributor

Do you like hacky quick fixes? Well, we have a job for you. Add some css that adds {display: none} for the edit pencil icon on every page of the guides, and also hides the search bar.

Why? We are deploying the Octane Guides Preview to a special staging app and neither of these things will work. It's important for UX.

This work should branch from the existing octane and make a PR back into octane. Thanks for your help!
@jenweber jenweber added Octane help wanted Extra attention is needed time-sensitive It is important that this task be finished very quickly labels Mar 15, 2019
thisduck added a commit to thisduck/guides-source that referenced this issue Mar 15, 2019
@thisduck
ember-learn#611 Hiding edit pencil and search bar globally for now.
7ecf8fe
@thisduck thisduck mentioned this issue Mar 15, 2019
Merged
@rwjblue
Copy link
Contributor

rwjblue commented Mar 15, 2019

Closed by #616

@rwjblue rwjblue closed this as completed Mar 15, 2019
lenoraporter pushed a commit to lenoraporter/guides-source that referenced this issue Jul 19, 2020
@thisduck @lenoraporter
ember-learn#611 Hiding edit pencil and search bar globally for now.
3461034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed Octane time-sensitive It is important that this task be finished very quickly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @jenweber