Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The context parameter is no more (+formatting) #135

Merged
merged 2 commits into from
Aug 25, 2018

Conversation

pablobm
Copy link
Contributor

@pablobm pablobm commented Aug 19, 2018

The context parameter was removed from find and findAll in ember-test-helpers. Currently, trying to use it will get you an exception, as can be seen in this PR: emberjs/ember-test-helpers#358 That's the first of these two commits.

Since I was at it, I added a second commit to try make the formatting less awkward. Currently it tries to be a definition list formatted as nested lists, but doesn't really achieve that. From the Showdown documentation[1], I see that the correct way to do that would be with 4 spaces, rather than the current 2. However I went to see what this would look like if instead I put both term+definition in a single list item:

alternative-formatting

Thoughts?

[1] Nested lists with Showdown: https://github.com/showdownjs/showdown/wiki/Showdown's-Markdown-syntax#nested-lists

@jenweber jenweber merged commit 4ae01e7 into ember-learn:master Aug 25, 2018
@jenweber
Copy link
Contributor

Thanks! This is an improvement on all fronts. I prefer the simpler markdown too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants