The context
parameter is no more (+formatting)
#135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
context
parameter was removed fromfind
andfindAll
inember-test-helpers
. Currently, trying to use it will get you an exception, as can be seen in this PR: emberjs/ember-test-helpers#358 That's the first of these two commits.Since I was at it, I added a second commit to try make the formatting less awkward. Currently it tries to be a definition list formatted as nested lists, but doesn't really achieve that. From the Showdown documentation[1], I see that the correct way to do that would be with 4 spaces, rather than the current 2. However I went to see what this would look like if instead I put both term+definition in a single list item:
Thoughts?
[1] Nested lists with Showdown: https://github.com/showdownjs/showdown/wiki/Showdown's-Markdown-syntax#nested-lists