Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces EmberArray with tracked property in "Looping through lists" #1758

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Replaces EmberArray with tracked property in "Looping through lists" #1758

merged 3 commits into from
Dec 16, 2021

Conversation

locks
Copy link
Contributor

@locks locks commented Dec 16, 2021

Fixes #1756.

@locks locks requested review from jenweber and a team December 16, 2021 03:48
@locks locks mentioned this pull request Dec 16, 2021
Closed
18 tasks
jenweber
jenweber approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was one missing @tracked that we added. Other than that, looks good! Thank you!

guides/release/components/looping-through-lists.md Outdated Show resolved Hide resolved
@jenweber jenweber merged commit aac5cae into master Dec 16, 2021
@jenweber jenweber deleted the looping-through-lists-ember-array branch December 16, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenweber jenweber jenweber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove A() usage from "Looping through lists" guide
2 participants
@locks @jenweber