Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC-774] Remove documentation for implicit route model #1907

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Mar 7, 2023

RFC-774

I believe it is safe to merge this now even before the deprecation has been merged, but I'm open to alternative ways to handle this.

emberjs/ember.js#20376

@jenweber
Copy link
Contributor

Thank you! I like the prose you added. However, the soon to be deprecated behavior is such a big gotcha, so I think it may still merit a small, concise warning about the behavior when someone does nothing with the model hook. I have a hypothesis that this behavior is one of Ember’s main stumbling blocks for beginners. For best developer experience, I think we would want to keep the warning until support is dropped in a major. What do you think about that?

Someone would see a deprecation warning to help guide them too, but my experience is that those accumulate, and devs may ignore them due to alert fatigue.

Regardless, I don’t think we need to wait for the deprecation to land in order to ship this. The guides should represent the general way we want to encourage people to write ember apps, and we don’t need to cover all approaches in the guides.

@wagenet wagenet force-pushed the remove-documentation-for-implict-route-model branch from 33504de to 985faf3 Compare June 29, 2023 14:07
@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit fd17fb6
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/649d92669c8a4700082ccbe1
😎 Deploy Preview https://deploy-preview-1907--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you a small wording change. We can emphasize our product priorities of nicer dev experience.

@wagenet wagenet merged commit ba3940a into master Jun 29, 2023
@wagenet wagenet deleted the remove-documentation-for-implict-route-model branch June 29, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants