Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angle-bracket-ize tutorial/autocomplete-component.md #702

Merged
merged 4 commits into from
Apr 2, 2019
Merged

Angle-bracket-ize tutorial/autocomplete-component.md #702

merged 4 commits into from
Apr 2, 2019

Conversation

zachgarwood
Copy link
Contributor

Updated the built-in components to use angle bracket syntax. See #692

@chancancode chancancode mentioned this pull request Mar 29, 2019
Closed
16 tasks
@zachgarwood
Clarified @value argument vs value property
1bd1b2f 
Also, I reformatted the paragraphs in question to be <80 characters
long.

(#692)
@zachgarwood
Copy link
Contributor Author

I followed @chancancode 's suggestions and did some minor reformatting.

@zachgarwood
Copy link
Contributor Author

I implemented @chancancode / @locks 's suggested change.

@locks locks merged commit f555332 into ember-learn:octane Apr 2, 2019
@locks
Copy link
Contributor

locks commented Apr 2, 2019

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancancode chancancode chancancode approved these changes

@pzuraq pzuraq pzuraq approved these changes

@locks locks locks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zachgarwood @locks @chancancode @pzuraq