Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating upgrading editions.md #709

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Updating upgrading editions.md #709

merged 2 commits into from
Apr 2, 2019

Conversation

mdbiscan
Copy link
Contributor

Updated the built-in components to use angle bracket syntax. See #692

Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make straight conversions, you need to prefix arguments with @, and then you need curlies on the right hand side, so something like <Input @value={{this.componentProperty}}.

guides/release/upgrading/editions.md Outdated Show resolved Hide resolved
guides/release/upgrading/editions.md Outdated Show resolved Hide resolved
guides/release/upgrading/editions.md Outdated Show resolved Hide resolved
@mdbiscan
Copy link
Contributor Author

mdbiscan commented Apr 1, 2019

To make straight conversions, you need to prefix arguments with @, and then you need curlies on the right hand side, so something like <Input @value={{this.componentProperty}}.

I get that. I was taken aback on @value={{@value}}. Thanks for the protips!

@locks locks merged commit ffd5b4c into ember-learn:octane Apr 2, 2019
@locks
Copy link
Contributor

locks commented Apr 2, 2019

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants