Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish converting link-to and input to angle brackets #797

Merged
merged 6 commits into from
May 27, 2019
Merged

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented May 20, 2019

Also added labels to form inputs, partially addresses #798

@jenweber jenweber requested a review from rwjblue May 21, 2019 19:28
Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small inline suggestion, but otherwise LGTM

guides/release/templates/input-helpers.md Outdated Show resolved Hide resolved
@jenweber
Copy link
Contributor Author

I think I need to put some @ in front of these - will add another commit after I do some testing.

guides/release/templates/input-helpers.md Outdated Show resolved Hide resolved
guides/release/templates/input-helpers.md Outdated Show resolved Hide resolved
guides/release/templates/input-helpers.md Outdated Show resolved Hide resolved
guides/release/templates/input-helpers.md Outdated Show resolved Hide resolved
guides/release/templates/input-helpers.md Outdated Show resolved Hide resolved
@rwjblue
Copy link
Contributor

rwjblue commented May 24, 2019

@jenweber - I think I got them 😸

@locks locks merged commit 60c2a62 into octane May 27, 2019
@locks locks deleted the linkto-and-input branch May 27, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants