Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octane - Replace some references to Computed Properties with Tracked #805

Merged
merged 5 commits into from
May 23, 2019

Conversation

jenweber
Copy link
Contributor

This is incremental work towards #669

guides/release/applications/dependency-injection.md Outdated Show resolved Hide resolved
guides/release/applications/dependency-injection.md Outdated Show resolved Hide resolved
guides/release/controllers/index.md Outdated Show resolved Hide resolved
guides/release/models/relationships.md Outdated Show resolved Hide resolved
guides/release/routing/query-params.md Outdated Show resolved Hide resolved
@jenweber jenweber requested a review from rwjblue May 21, 2019 20:53
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenweber this makes sense to me.

@jenweber jenweber merged commit 2d4cd3b into octane May 23, 2019
@jenweber jenweber deleted the computed-tracked branch May 23, 2019 13:50
lenoraporter pushed a commit to lenoraporter/guides-source that referenced this pull request Jul 19, 2020
…mber-learn#805)

* change some mentioned of CPs to tracked/getters

* replace more CPs

* Apply suggestions from code review

Co-Authored-By: Robert Jackson <[email protected]>

* update following rwjblue's suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants