feat: patch ember-cli-babel
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2020
This was referenced May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1. Closes #2.
This removes the not reliably working
patch-packagehackery and replaces it with different h4xx.We now patch the consuming parent's instance of
ember-cli-babelto rewrite the{ cached } from '@glimmer/tracking'import toEmber._cached, just before applying the other rewrites frombabel-plugin-ember-modules-api-polyfill.I think this is a quite mean hack, but given that we can remove it, as soon as the RFC gets accepted & ember-cli/ember-rfc176-data#322 gets merged, I think it's acceptable as an intermittent solution.
I'd still like add a more sophisticated test harness with a monorepo setup, so test that this works reliably in apps, addons, engines and Embroider.