Ensure polyfill works properly with Ember 3.27+

[mydea]

Based on ef4's comment here: #70 (comment)

This PR changes how the polyfill works by simply rewriting import { cached } from '@glimmer/tracking' to import { cached } from 'ember-cached-decorator-polyfill'.

It uses a simple regex to do so - I added some tests covering all the different import scenarios I could think of (as @glimmer/tracking only has a single other relevant import tracked, it is relatively straightforward).

I hope I didn't miss anything critical 😅 but the tests are passing and it seems to be working just fine.

[mydea]

FYI, I have tried this in our medium-sized app with ember-source 3.27 (and TypeScript) and it worked fine!

[ef4]

Thanks for working on this.

My concern with this PR is that the regex-based rewriting looks pretty fragile. If @glimmer/tracking adds any new exported names, it's likely to break.

Instead of replacing the existing babel plugin with a regex, I think it would be better to modify the plugin so it does the rewriting of the imported path.

[mydea]

OK, I made a second try, now rewriting the import via the babel AST. I did not cover re-exporting it, but IMHO that seems OK to me. I did not 100% see through how I would make the re-export declaration work, I am not necessarily a babel-AST-pro 😅

[rwjblue]

Thanks for picking this up! I left one minor comment (removing that new dependency that we don't need any more), but it should be good to go once that is fixed.

[acorncom]

@mydea just pushed up a simple repro I'd built to test things as part of #77 Ran it against your branch here and it seems to still be failing

[mydea]

True, I can see the same in our app. I will check it out and see if I can make it work..!

[mydea]

I can also reproduce it by updating the addon itself to [email protected] (which at least makes fixing it easier, I guess)

[mydea]

OK, seems from ember-cli-babel 7.23->7.24 the _getEmberModulesAPIPolyfill hook is dropped, leading to the whole babel plugin not running.

[mydea]

So, I have now refactored it again, it is much nicer now actually :D I am using ember-cli-babel-plugin-helpers to just add the plugin in a regular fashion, without patching anything. I have also updated ember-cli-babel in this addon itself to latest, and the tests are passing fine. Can @acorncom you try it again in the repro?

[acorncom]

Confirmed that it's no longer crashing in my repro and that the @cache decorator seems to be working smoothly

[rwjblue]

This is much better, thank you @mydea!

[nightire]

Unfortunately, I am still seeing the error:

Uncaught TypeError: decorator is not a function

I'm pretty sure I had the latest ember-cached-decorator-polyfill installed, and worse is it failed even with [email protected]

[mydea]

Unfortunately, I am still seeing the error:

Uncaught TypeError: decorator is not a function

I'm pretty sure I had the latest ember-cached-decorator-polyfill installed, and worse is it failed even with [email protected]

Hmm, I just tried it in our app:

[email protected]
[email protected]
[email protected]

And I have tried it with:

[email protected]
[email protected]
[email protected]

Both of these setups worked fine for me.

[nightire]

Hmm, I just tried it in our app:

[email protected]
[email protected]
[email protected]

And I have tried it with:

[email protected]
[email protected]
[email protected]

Both of these setups worked fine for me.

I have tried these combinations as well but still no luck, I even use resolutions to constraint these versions, and the error still remains. I'm out of options now.😕