Use destroyables implementation in Ember 3.20+ #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may want to revert this back to 3.16 later, but making 3.20 the default makes it much easier to test / iterate on the 3.20 fixes.
Will need to stay disabled until emberjs/ember.js#19056 lands and is backported.
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the polyfill to use the real (hopefully) final API that landed in Ember 3.20. Even though the actual API was implemented in 3.20 the public API (to be importable from
@ember/destroyables) will not be published for another couple versions (likely 3.22). In the meantime, this PR uses the internal implementation directly.