fix named block #15
Merged
fix named block #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
patricklx
force-pushed
the
fix-named-block
branch
from
f1839e1
to
76c86b8
Compare
| @@ -267,12 +267,12 @@ module.exports.preprocessGlimmerTemplates = function preprocessGlimmerTemplates( | |||
| let start = n.range[0]; | |||
| let codeSlice = code.slice(...n.range); | |||
| for (const part of n.tag.split('.')) { | |||
| const regex = new RegExp(`\\b${part}\\b`); | |||
| let pattern = `\\b${part}\\b`; | |||
| if (part.startsWith(':')) { | |||
There was a problem hiding this comment.
What's the significance of the leading \b vs not?
There was a problem hiding this comment.
\b is only an assertion that we are at a word boundary. so either before or after there is a word character and at the other side there is a non-word character (special character).
But with named block, we are not at a word boundary since there are no word characters at the beginning. : is not a word character. but with : we are sure that we match the correct part
NullVoxPopuli
previously approved these changes
Dec 29, 2023
patricklx
commented
Dec 29, 2023
|
|
||
| const name = n?.name ?? n.tag; | ||
|
|
||
| if (htmlTags.includes(name)) { |
There was a problem hiding this comment.
it's possible to override plain html tags with block params
patricklx
force-pushed
the
fix-named-block
branch
from
b8e1e87
to
71085b5
Compare
NullVoxPopuli
approved these changes
Dec 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the regex
\b:custom\bwasn't able to match the tag name...https://regex101.com/r/U2MlJe/2