fix rust utf8 ranges vs js utf16 ranges #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Dec 29, 2023
NullVoxPopuli
commented
Dec 30, 2023
| @@ -295,7 +315,7 @@ module.exports.preprocessGlimmerTemplates = function preprocessGlimmerTemplates( | |||
| // for blocks {{x as |b|}} the block range does not contain the block params... | |||
There was a problem hiding this comment.
is this part still needed? the blockRange? it come from one of the other fix PRs, but it causes an error on this branch
There was a problem hiding this comment.
hmm, it should be required, yes
patricklx
force-pushed
the
byte-verses-character-index-repro
branch
from
708caa5
to
2d04b33
Compare
this is more correct.
patricklx
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same issue brought up here:
content-tagupdated here: https://github.com/embroider-build/content-tag/#parsed