Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recap video of EmberFest 2021 #300

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Add recap video of EmberFest 2021 #300

merged 1 commit into from
Jul 27, 2022

Conversation

inesoaresilva
Copy link
Collaborator

It adds a section to watch the video of EmberFest 2021

@inesoaresilva inesoaresilva linked an issue Jul 25, 2022 that may be closed by this pull request
@marcoow
Copy link
Member

marcoow commented Jul 25, 2022

the embed doesn't seem to work?

Bildschirmfoto 2022-07-25 um 16 18 19

@oscard0m
Copy link
Collaborator

oscard0m commented Jul 25, 2022

the embed doesn't seem to work?

Bildschirmfoto 2022-07-25 um 16 18 19

To make it work you need to apply the proper YouTube embedded code:

Go to the video -> Share -> Embeded

Context here: https://stackoverflow.com/a/69169484/3237248

Copy link
Collaborator

@oscard0m oscard0m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comment about adding /embed YouTube videos.

@inesoaresilva
Copy link
Collaborator Author

To make it work you need to apply the proper YouTube embedded code:

Go to the video -> Share -> Embeded

Context here: https://stackoverflow.com/a/69169484/3237248

Thanks!
Should be working now :)

@marcoow
Copy link
Member

marcoow commented Jul 25, 2022

Would it look better with the same style that we're using for "Past speakers" with the same background color, the croissants etc.? If we want to go with the blue background, we'd need to remove the bar between the blue background and the image above:

Bildschirmfoto 2022-07-25 um 17 28 32

Also the text flows very wide – we should use a maximum width for the paragraph, check the paragraph below in the past speakers section for reference.

@inesoaresilva
Copy link
Collaborator Author

Would it look better with the same style that we're using for "Past speakers" with the same background color, the croissants etc.? If we want to go with the blue background, we'd need to remove the bar between the blue background and the image above:

Bildschirmfoto 2022-07-25 um 17 28 32

Also the text flows very wide – we should use a maximum width for the paragraph, check the paragraph below in the past speakers section for reference.

I also like with the styling of the croissants divider.
The blue background is nice too but I don't know if it would be that easy to remove that line anyway, the image above doesn't have a straight line causing this space.

Right now, there is a rule in the sections to always apply a padding-bottom of 128px, I'm wondering if it wouldn't make sense to make this space smaller in smaller screens, it is a lot of space for padding that could be used to show more info?

@marcoow marcoow merged commit 6753a88 into master Jul 27, 2022
@marcoow marcoow deleted the add-mood-video-2021 branch July 27, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Rome mood video
3 participants