Preserve used imports when interoperating with transform-typescript #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@babel/plugin-transform-typescript` removes unused imports because it assumes they're types (yuck). That's how TS behaves so it's at least understandable. However, it doesn't seem to respect the fact that our plugin is *emitting* code that *will* use the imports. This adds a failing test.
Builds off #31 to fix #30. Instead of keeping *everything* as in #31 (which is not safe in general), we use the `pre` to take a snapshot of available imports and then only when we discover that a template wants to use a name that is not in scope do we check if it was in the original set of available imports and reintroduce an import for it.
ef4
force-pushed
the
preserve-used-imports
branch
from
9d789ed
to
3d9f9d4
Compare
|
I confirmed locally that this PR fixes ember-cli/ember-template-imports#211 |
ef4
changed the title
|
Does this also work with amd transform? Would be good to have a test for it too . Btw, thanks for basing this on my pr. Much appreciated. if this works well, also with AMD transform, then this is better |
|
I also saw now that amd transform runs an program:exit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off #31 to fix #30.
Instead of keeping everything as in #31 (which is not safe in general), we use the
preto take a snapshot of available imports and then only when we discover that a template wants to use a name that is not in scope do we check if it was in the original set of available imports and reintroduce an import for it.