-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot set relationship in 3.2.0 #5517
Comments
Maybe also related to: #5511 |
This bug might be fixed now? |
It is fixed. |
@runspired is there a good release to test this in? |
@jrjohnson fix was released in all stable versions |
Oh OK, I still have a possibly related issue in 3.3.1. I will try and create a useful reproduction and a new ticket. |
Same here, I tried emberjs/data#master, but still having problems. Currently stuck on 2.18.0 |
@amk221 I have mega doubts that this issue still exists on master without a reproducible failing scenario. I did look at the repro you mentioned here: amk221/-ember-data-geturl-not-a-function@3ab9aa7 and as others mentioned the test itself is incorrect and passes when fixed. I noticed your comments:
However we have tests that cover exactly this scenario, so without a clear test setup showing this problem still exists for some set of conditions I'm inclined to believe it's more likely an issue with app code. |
ok, thank you for your input. I'll try to amalgamate the two and come up with a better failing case. |
…berjs#5533) * adds failing tests for emberjs#5511 and emberjs#5517 * add a test for emberjs#5525 that suspiciously passes * adds test for emberjs#5522 isEmpty issue * run prettier * fix issue with proxy * upgrade test for potential issue with create, still passes * fix emberobserver issue for missing data member in payloads
I still get |
The bug is here. |
We're seeing the same issue as @dmarkin in |
Clearing out the relationship then setting it no longer works.
e.g:
Passing in 2.18.2: Twiddle
Switch to 3.2.0 for a failure
The text was updated successfully, but these errors were encountered: