Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate jQuery detection to using static build time macro #6093

Closed
rwjblue opened this issue May 8, 2019 · 3 comments
Closed

Migrate jQuery detection to using static build time macro #6093

rwjblue opened this issue May 8, 2019 · 3 comments
Labels
Infra/CI/DX 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166

Comments

@rwjblue
Copy link
Member

rwjblue commented May 8, 2019

Once embroider-build/embroider#162 has been implemented, update packages/adapter/addon/rest.js to leverage the new functionality in the useFetch detection.
@rwjblue rwjblue mentioned this issue May 8, 2019
Merged
@runspired runspired mentioned this issue Sep 11, 2019
Closed
@jrjohnson jrjohnson mentioned this issue Nov 19, 2019
Closed
@runspired
Copy link
Contributor

With the landing of #6737 we could use that to add/remove both our jquery and fetch codepaths.

@runspired runspired added the 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 label Nov 19, 2019
@rwjblue Octobox
Copy link
Member Author

rwjblue commented Nov 20, 2019

Ya, sounds good to me...

@runspired
Copy link
Contributor

closing in favor of deprecation stripping which will be made available when implementing emberjs/rfcs#790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Infra/CI/DX 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @runspired