[BUGFIX release] Fix fetch detection in FastBoot. #6092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior detection of when to use fetch vs when to use jQuery was not properly acounting for the `fastboot` case when `ember-fetch` is not present and a `fetch` global is not present. In that scenario, `najax` would be present (provided by `fastboot` itself). We already had the correct logic in `_ajax`, however the `useFetch` computed was returning `true` which prevented the `najax` supported branch from being used.
rwjblue
added a commit
to rwjblue/ember-data-fastboot-bug
that referenced
this pull request
May 8, 2019
|
Tested this linked against the reproduction app by @mansona and it fixes the latest regression. Test out in mansona/ember-data-fastboot-bug#1. |
|
I've tested this locally and I'm 👍 that it has fixed this particular bug |
igorT
reviewed
May 8, 2019
| let shouldUseFetch = (ENV && ENV._JQUERY_INTEGRATION) === false || jQ === undefined; | ||
|
|
||
| return shouldUseFetch; | ||
| // TODO: migrate to static build time detection ala https://github.com/embroider-build/embroider/issues/162 |
igorT
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior detection of when to use fetch vs when to use jQuery was not properly accounting for the
fastbootcase whenember-fetchis not present and afetchglobal is not present. In that scenario,najaxwould be present (provided byfastbootitself).We already had the correct logic in
_ajax, however theuseFetchcomputed was returningtruewhich prevented thenajaxsupported branch from being used.