Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active-model-adapter to partner tests #7218

Closed
igorT opened this issue Jun 7, 2020 · 3 comments
Closed

Add active-model-adapter to partner tests #7218

igorT opened this issue Jun 7, 2020 · 3 comments

Comments

@igorT
Copy link
Member

igorT commented Jun 7, 2020

Especially as we will be refactoring the adapter/serializer area soon

@dcyriller
Copy link
Contributor

dcyriller commented Jun 16, 2020

@igorT I've started to look into this. I'm interested - being a user of active-model-adapter.

To add active-model-adapter to partner tests, I will open a PR to remove bower usage there.

But I also have a question... Is it ok to also not publish anymore the package on rubygems? Indeed, it looks that active-model-adapter is published on rubygems under the name active-model-adapter-source. It would be used by the ember-rails project to add frontend capabilities to a rails app. None of the projects are deprectated, but I assume that consumming an ember addon through the ruby gem is not recommended anymore - and difficult to support. After that, we'd release a 3.x version. If any patch needs to be applied on active-model-adapter-source, it would be done on a 2.x branch.

@dcyriller
Copy link
Contributor

I see a PR has already been started to drop bower 🎉 adopted-ember-addons/active-model-adapter#121

@runspired
Copy link
Contributor

closing in favor of #7529 7529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants