Set the ruby gem under maintenance mode (not the ember addon!) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. I wonder why Travis fails |
|
Because it downloads and runs latest yarn in a Node 4 environnement 😢 |
This was referenced Sep 24, 2020
Closed
|
Wanna give it a quick rebase and I'll merge? |
This comment has been minimized.
This comment has been minimized.
|
@dcyriller Seems like CI is now failing with a different error |
|
Seems good now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ember addon is also published to rubygems under the name active-model-adapter-source.
This PR proposes to change this first sentence tense: "This ember addon was published to rubygems.". From now on, only patch releases (probably on a 2.x branch) would get published to rubygems.
I don't think that integrating an ember addon through a ruby gem is recommended anymore. And active_model_serializers itself has gone under maintenance mode.
related issue in ember-data: emberjs/data#7218
cc @igorT