Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation with yarn 1.22.18 fails #8088

Closed
Turbo87 opened this issue Jul 28, 2022 · 5 comments · Fixed by #8089
Closed

Installation with yarn 1.22.18 fails #8088

Turbo87 opened this issue Jul 28, 2022 · 5 comments · Fixed by #8089

Comments

@Turbo87
Copy link
Member

Turbo87 commented Jul 28, 2022

Reproduction

rust-lang/crates.io#4801

Description

When an older yarn version is used then installation of ember-data v4.6.0 fails with:

[email protected]: The engine "yarn" is incompatible with this module. Expected version "1.22.19". Got "1.22.18"

This appears to be caused by https://github.com/emberjs/data/pull/8027/files#diff-336570c014b223552c15564402521af39202b04432d7fdc3c0081ed6d3540373R91, which introduced a very restrictive engines.yarn key in the package.json file.

@runspired
Copy link
Contributor

We should remove the yarn key from the individual packages, it probably only needs to be in the root. While it's nice for folks not using Volta it's obviously bad to hoist that onto outside installs.

@ef4
Copy link
Contributor

ef4 commented Jul 28, 2022

This is currently breaking in Embroider's CI if somebody wants to see the failure:

https://github.com/embroider-build/embroider/runs/7566490423?check_suite_focus=true

@runspired
Copy link
Contributor

@ef4 working on removal and back port now. Was not the intention to foist a yarn version on the community 😓

@runspired runspired linked a pull request Jul 28, 2022 that will close this issue
@runspired
Copy link
Contributor

Released as 4.6.1 and 4.7 beta 1 and 4.8 alpha 1

@Turbo87
Copy link
Member Author

Turbo87 commented Jul 29, 2022

thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants