Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Embroider workarounds in test embroider-basic-compat #8748

Closed
mkszepp opened this issue Jul 28, 2023 · 1 comment
Closed

Remove Embroider workarounds in test embroider-basic-compat #8748

mkszepp opened this issue Jul 28, 2023 · 1 comment

Comments

@mkszepp
Copy link
Contributor

mkszepp commented Jul 28, 2023

In EmberData there are some workarounds for embroider. Cause of this workaround the ember-data embroider tests were not failed in v4.12.x and this has produced this side-effect embroider-build/embroider#1506 (comment) in consumer app.

For EmberData v5 there makes no different, but ember data v4.12.x (maybe also 4.11.x) there is necessary to add workaround in consumer app to get run ember-data.

compatAdapters: new Map([
['@ember-data/store', null],
['@ember-data/record-data', null],
['@ember-data/serializer', null],
['@ember-data/adapter', null],
['@ember-data/model', null],
['@ember-data/debug', null],
['@ember-data/tracking', null],
['@ember-data/request', null],
['ember-data', null],
]),
packageRules: [
{
package: '@ember-data/store',
addonModules: {
'-private.js': {
dependsOnModules: ['@ember-data/json-api'],
},
},
},
],

We should remove this lines for ember-data v5 & after embroider release also for ember-data v4

@runspired
Copy link
Contributor

runspired commented Jul 28, 2023

These lines are here because we are not compatible with embroider if embroider is secretly trying to fix things. Embroider should never be providing a compat adapter 4.12+. Even once embroider has removed them I think we should keep this just in case, I don't want to get trolled thinking there's support where there isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants