Embroider optimized fails with Ember Data 4.12.x

[jrjohnson]

In an addon with ember-data installed the embroider optimized scenario fails with:

Uncaught Error: Could not find module `@ember-data/store` imported from `(require)

Steps to reproduce

1. $ ember addon emberFiveDataFourEmbroider
2. $ ember install [email protected]
3. $ ember try:one embroider-optimized

Just in case I tried it after the release of v3.1.4 and it still fails. It passes with ember-data v5.x (or least doesn't fail in this obvious way).

[Windvis]

It seems the compat adapters are disabled on ember-data 4.11.1+. It looks like v4.* isn't Embroider compatible and the adapters only hid the underlying issue?

@ember-data/debug is still importing from @ember-data/store without listing it as a dependency: https://github.com/emberjs/data/blob/00e572aa2d4315fda5aeba03540e9d81be6297bb/packages/debug/addon/setup.js#L3

In v5 that file is removed so that could explain why it works there.

So I think enabling (some of) the compat adapters might be a workaround if this can't be easily fixed on the Ember Data side.

Edit: I was able to get it working again by enabling the @ember-data/debug and @ember-data/store compat adapters.

[Windvis]

Small update: @ember-data/debug 4.12.3 now lists @ember-data/store as a peerDependency, but I still see the same runtime error after updating. So something else might still be going on. (I deleted the node_modules/.embroider folder to be sure).

[jrjohnson]

Confirmed as still failing with ember-data v4.12.3 as well as v3.2.0 of embroider libs with the same error message:
not ok 1 Chrome 114.0 - [undefined ms] - Global error: Uncaught Error: Could not find module @ember-data/storeimported from(require) at http://localhost:7357/assets/vendor.js, line 254

I also touched up the issue name and the reproduction steps.

[mkszepp]

There were added some new compactAdapters for EmberData in #1435. One of this is causing problem with ember-data v4.12.x

Workaround is to disable the compactAdapter in app:

return require('@embroider/compat').compatBuild(app, Webpack, {
    skipBabel: [
      {
        package: 'qunit',
      },
    ],
    staticAddonTestSupportTrees: true,
    staticAddonTrees: true,
    staticHelpers: true,
    staticComponents: true,
    compatAdapters: new Map([
      ['@ember-data/debug', null],
    ]),
  });