Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the version number in the javascript. #1051

Merged
merged 1 commit into from
Jun 25, 2013

Conversation

gunn
Copy link
Contributor

@gunn gunn commented Jun 25, 2013

For #1029 - expose the version number for debugging. Ember should be able to print it like so:

Ember.debug('-------------------------------');
Ember.debug('Ember.VERSION : ' + Ember.VERSION);
if (window.DS && DS.VERSION) {
  Ember.debug('DS.VERSION : ' + DS.VERSION);
} //...

stefanpenner added a commit that referenced this pull request Jun 25, 2013
Include the version number in the javascript.
@stefanpenner stefanpenner merged commit 9d2f62d into emberjs:master Jun 25, 2013
@stefanpenner
Copy link
Member

@gunn it would be nice if these versions could be registered on ember proper, and printed out in bulk when ember booted. I would prefer this to the proposed conditional in ember

@gunn
Copy link
Contributor Author

gunn commented Jun 25, 2013

@stefanpenner Great response time!

@gunn
Copy link
Contributor Author

gunn commented Jun 25, 2013

Perhaps something like:

Ember.libraryVersions = {};

And then in ember-data:

Ember.libraryVersions.DS = '0.13';

Which then gets iterated over to print versions?

@gunn gunn deleted the patch-1 branch June 25, 2013 02:34
@stefanpenner
Copy link
Member

@gunn I am uneasy about adding something on the Ember.libraryVersions , but something along these lines would be great.

@gunn
Copy link
Contributor Author

gunn commented Jun 25, 2013

Uneasy about what? 'libraryVersions' or similar would be defined by ember. Perhaps a less direct interface though:

Ember.registerLibraryVersion('DS', '0.13');

Ember would then register itself and libs like jquery.

@wycats
Copy link
Member

wycats commented Sep 3, 2013

@gunn I like your idea. Can you drive it forward?

@wycats wycats mentioned this pull request Sep 3, 2013
@gunn
Copy link
Contributor Author

gunn commented Sep 3, 2013

Okay, will do

@gunn
Copy link
Contributor Author

gunn commented Sep 6, 2013

Pull request at emberjs/ember.js#3345

@wycats
Copy link
Member

wycats commented Sep 6, 2013

@gunn do you want to submit a PR now to register the ED info?

@gunn
Copy link
Contributor Author

gunn commented Sep 6, 2013

@wycats yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants