-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the version number in the javascript. #1051
Conversation
Include the version number in the javascript.
@gunn it would be nice if these versions could be registered on ember proper, and printed out in bulk when ember booted. I would prefer this to the proposed conditional in ember |
@stefanpenner Great response time! |
Perhaps something like: Ember.libraryVersions = {}; And then in ember-data: Ember.libraryVersions.DS = '0.13'; Which then gets iterated over to print versions? |
@gunn I am uneasy about adding something on the Ember.libraryVersions , but something along these lines would be great. |
Uneasy about what? 'libraryVersions' or similar would be defined by ember. Perhaps a less direct interface though: Ember.registerLibraryVersion('DS', '0.13'); Ember would then register itself and libs like jquery. |
@gunn I like your idea. Can you drive it forward? |
Okay, will do |
Pull request at emberjs/ember.js#3345 |
@gunn do you want to submit a PR now to register the ED info? |
@wycats yep |
For #1029 - expose the version number for debugging. Ember should be able to print it like so: