Bring back relationship parameter for adapter findHasMany #2252
Conversation
Signed-off-by: Alessandro D'Aquino (elara) <[email protected]>
| @@ -99,7 +99,7 @@ test("A serializer can materialize a hasMany as an opaque token that can be lazi | |||
| throw new Error("Adapter's findMany should not be called"); | |||
| }; | |||
|
|
|||
| env.adapter.findHasMany = function(store, record, link) { | |||
| env.adapter.findHasMany = function(store, record, link, relationship) { | |||
| equal(link, "/posts/1/comments", "findHasMany link was /posts/1/comments"); | |||
There was a problem hiding this comment.
Wanna assert that the relationship is passed in here correctly?
There was a problem hiding this comment.
@igorT should I squash the two commits?
There was a problem hiding this comment.
@igorT I'm going to open a new PR with the squashed commits, will post here the new PR
Signed-off-by: Alessandro D'Aquino (elara) <[email protected]>
|
@igorT I hope you are still happy to merge this PR, I really need this so I can get rid of my patched version of ED, thanks. |
|
Looks good so far |
| @@ -431,7 +431,7 @@ export default Adapter.extend({ | |||
| @param {String} url | |||
| @return {Promise} promise | |||
| */ | |||
| findBelongsTo: function(store, record, url) { | |||
| findBelongsTo: function(store, record, url, relationship) { | |||
There was a problem hiding this comment.
Seems like you changed the type into a relationship in the HasMany, but not in the belongsTo? Also test?
There was a problem hiding this comment.
@igorT I didn't need to change it because the relationship parameter is already passed in: https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/store.js#L1788, and the tests already check for it: https://github.com/emberjs/data/blob/master/packages/ember-data/tests/integration/relationships/belongs_to_test.js#L178 or am I missing something here?
|
@igorT closing this PR in favour of a new one with squashed commits: #2263. Regarding |
Signed-off-by: Alessandro D'Aquino (elara) [email protected]