Created store.fetchById and store.fetchAll.
#2653
Merged
+163
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First steps to implement emberjs/rfcs#27 ping @igorT @fivetanley |
cibernox
force-pushed
the
split_store_fetch
branch
from
3460334
to
a01ea73
Compare
cibernox
changed the title
store.fetchById and store.fetchAll.store.fetchById and store.fetchAll.
cibernox
changed the title
store.fetchById and store.fetchAll.store.fetchById and store.fetchAll.
|
reping @igorT |
|
@fivetanley +1 :yolomerge: |
5 tasks
|
@cibernox We would like to merge this. Can you rebase and resolve the conflicts? |
|
#YOLOMERGE approved |
cibernox
force-pushed
the
split_store_fetch
branch
from
a01ea73
to
a946d19
Compare
|
Rebased. Awaiting #yolomerge 😀 |
cibernox
force-pushed
the
split_store_fetch
branch
from
a946d19
to
18ee225
Compare
* `store.fetchById` behaves like `store.fetch` used to. * `store.fetchAll` behaves like `store.find` called with only a type. * `store.fetch` is aliased to `store.fetchById` and deprecated.
cibernox
force-pushed
the
split_store_fetch
branch
from
18ee225
to
674678c
Compare
|
#yolo |
fivetanley
added a commit
that referenced
this pull request
Feb 3, 2015
Created `store.fetchById` and `store.fetchAll`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store.fetchByIdbehaves likestore.fetchused to.store.fetchis aliased tostore.fetchByIdand deprecated.store.fetchAllbehaves likestore.findAllused to.store.findAllis aliased tostore.fetchAll.Note that there was already a private method named
fetchAllwith a different signature. I've renamed it tostore._fetchAlland is used internally.