Raise error on unhandled deprecation warnings

packages/ember-data/lib/adapters/errors.js

@@ -79,7 +79,9 @@ AdapterError.prototype = Object.create(EmberError.prototype);
 */
 export function InvalidError(errors) {
   if (!Ember.isArray(errors)) {
-    Ember.deprecate('`InvalidError` expects json-api formatted errors.');
+    Ember.deprecate('`InvalidError` expects json-api formatted errors.', false, {
+      id: 'ember-data-invalidError-expects-json-api-errors'
+    });
     errors = errorsHashToArray(errors);
   }
   AdapterError.call(this, errors, 'The adapter rejected the commit because it was invalid');

packages/ember-data/lib/system/adapter.js

@@ -483,7 +483,9 @@ var Adapter = Ember.Object.extend({
   */
   shouldReloadAll: function(store, snapshotRecordArray) {
     var modelName = snapshotRecordArray.type.modelName;
-    Ember.deprecate(`The default behavior of shouldReloadAll will change in Ember Data 2.0 to always return false when there is at least one "${modelName}" record in the store. If you would like to preserve the current behavior please override shouldReloadAll in your adapter:application and return true.`);
+    Ember.deprecate(`The default behavior of shouldReloadAll will change in Ember Data 2.0 to always return false when there is at least one "${modelName}" record in the store. If you would like to preserve the current behavior please override shouldReloadAll in your adapter:application and return true.`, false, {
+      id: 'ember-data-shouldReloadAll'
+    });
     return true;
   },
 
@@ -504,7 +506,9 @@ var Adapter = Ember.Object.extend({
     @return {Boolean}
   */
   shouldBackgroundReloadRecord: function(store, snapshot) {
-    Ember.deprecate('The default behavior of `shouldBackgroundReloadRecord` will change in Ember Data 2.0 to always return true. If you would like to preserve the current behavior please override `shouldBackgroundReloadRecord` in your adapter:application and return false.');
+    Ember.deprecate('The default behavior of `shouldBackgroundReloadRecord` will change in Ember Data 2.0 to always return true. If you would like to preserve the current behavior please override `shouldBackgroundReloadRecord` in your adapter:application and return false.', false, {
+      id: 'ember-data-shouldBackgroundReloadRecord'
+    });
     return false;
   },
 

packages/ember-data/lib/system/store.js

@@ -1284,7 +1284,9 @@ Store = Service.extend({
     @deprecated
   */
   metadataFor: function(modelName) {
-    Ember.deprecate("`store.metadataFor()` has been deprecated. You can use `.get('meta')` on relationships and arrays returned from `store.query()`.");
+    Ember.deprecate("`store.metadataFor()` has been deprecated. You can use `.get('meta')` on relationships and arrays returned from `store.query()`.", false, {
+      id: 'ember-data-metadataFor'
+    });
     return this._metadataFor(modelName);
   },
 
@@ -1310,7 +1312,9 @@ Store = Service.extend({
     @deprecated
   */
   setMetadataFor: function(modelName, metadata) {
-    Ember.deprecate("`store.setMetadataFor()` has been deprecated. Please return meta from your serializer's `extractMeta` hook.");
+    Ember.deprecate("`store.setMetadataFor()` has been deprecated. Please return meta from your serializer's `extractMeta` hook.", false, {
+      id: 'ember-data-setMetadataFor'
+    });
     this._setMetadataFor(modelName, metadata);
   },
 
@@ -1690,7 +1694,9 @@ Store = Service.extend({
     if (Ember.typeOf(modelNameArg) === 'object' && Ember.typeOf(dataArg) === 'undefined') {
       data = modelNameArg;
     } else {
-      Ember.deprecate('store.push(type, data) has been deprecated. Please provide a JSON-API document object as the first and only argument to store.push.');
+      Ember.deprecate('store.push(type, data) has been deprecated. Please provide a JSON-API document object as the first and only argument to store.push.', false, {
+        id: 'ember-data-store#push(type, data)'
+      });
       Ember.assert("Expected an object as `data` in a call to `push` for " + modelNameArg + " , but was " + Ember.typeOf(dataArg), Ember.typeOf(dataArg) === 'object');
       Ember.assert("You must include an `id` for " + modelNameArg + " in an object passed to `push`", dataArg.id != null && dataArg.id !== '');
       data = _normalizeSerializerPayload(this.modelFor(modelNameArg), dataArg);
@@ -1888,7 +1894,10 @@ Store = Service.extend({
   */
   pushMany: function(modelName, datas) {
     Ember.assert(`Passing classes to store methods has been removed. Please pass a dasherized string instead of ${Ember.inspect(modelName)}`, typeof modelName === 'string');
-    Ember.deprecate('Using store.pushMany() has been deprecated since store.push() now handles multiple items. You should use store.push() instead.');
+    Ember.deprecate('Using store.pushMany() has been deprecated since store.push() now handles multiple items. You should use store.push() instead.', false, {
+      id: "ember-data-pushMany"
+    });
+
     var length = datas.length;
     var result = new Array(length);
 

packages/ember-data/tests/unit/store/push-test.js

@@ -184,7 +184,7 @@ test("Calling push on normalize allows partial updates with raw JSON", function
   equal(person.get('lastName'), "Jackson", "existing fields are untouched");
 });
 
-test("Calling push with a normalized hash containing related records returns a record", function() {
+test("DEPRECATED - Calling push with a normalized hash containing related records returns a record", function() {
   var number1, number2, person;
   run(function() {
     number1 = store.push('phone-number', {
@@ -198,16 +198,19 @@ test("Calling push with a normalized hash containing related records returns a r
       number: '5552121',
       person: 'wat'
     });
+  });
 
-    person = store.push('person', {
-      id: 'wat',
-      firstName: 'John',
-      lastName: 'Smith',
-      phoneNumbers: [number1, number2]
+  run(function() {
+    expectDeprecation(function() {
+      person = store.push('person', {
+        id: 'wat',
+        firstName: 'John',
+        lastName: 'Smith',
+        phoneNumbers: [number1, number2]
+      });
     });
   });
 
-
   deepEqual(person.get('phoneNumbers').toArray(), [number1, number2], "phoneNumbers array is correct");
 });
 

tests/ember-configuration.js

@@ -15,6 +15,7 @@
 
   // Handle testing feature flags
   ENV['ENABLE_OPTIONAL_FEATURES'] = !!QUnit.urlParams.enableoptionalfeatures;
+  ENV['RAISE_ON_DEPRECATION'] = true;
 
   window.async = function(callback, timeout) {
     var timer;

tests/ember-data-setup.js

@@ -1,5 +1,21 @@
 ;(function() {
 
+  // Since store.pushMany is used pretty heavily inside the tests, fixing all
+  // the deprecation warnings at once would be a big changeset. That's why the
+  // log level for this deprecation is set to LOG, so the deprecations are
+  // logged but they do not result in a failed test.
+  Ember.Debug._addDeprecationLevel("ember-data-pushMany", Ember.Debug._deprecationLevels.LOG);
+
+  Ember.Debug._addDeprecationLevel("ember-data-store#push(type, data)", Ember.Debug._deprecationLevels.LOG);
+
+  Ember.Debug._addDeprecationLevel("ember-data-shouldBackgroundReloadRecord", Ember.Debug._deprecationLevels.LOG);
+  Ember.Debug._addDeprecationLevel("ember-data-shouldReloadAll", Ember.Debug._deprecationLevels.LOG);
+
+  Ember.Debug._addDeprecationLevel("ember-data-metadataFor", Ember.Debug._deprecationLevels.LOG);
+  Ember.Debug._addDeprecationLevel("ember-data-setMetadataFor", Ember.Debug._deprecationLevels.LOG);
+
+  Ember.Debug._addDeprecationLevel("ember-data-invalidError-expects-json-api-errors", Ember.Debug._deprecationLevels.LOG);
+
   Ember.RSVP.configure('onerror', function(reason) {
     // only print error messages if they're exceptions;
     // otherwise, let a future turn of the event loop