[BUGFIX BETA CANARY] Add ember-decorators-polyfill dep to @ember-data/store #6321
Conversation
…/store Extracted from emberjs#6098 emberjs#6249 refactored `Store` to a class. As part of this refactoring, `Store#defaultAdapter` was implemented using the `@computed` decorator. Using the `@computed` decorator requires Ember 3.10+. This adds [`ember-decorators-polyfill`](https://github.com/pzuraq/ember-decorators-polyfill) as a dependency to `@ember-data/store` to add support for Ember < 3.10.
HeroicEric
force-pushed
the
add-ember-decorators-polyfill
branch
from
5888149
to
bbb3c16
Compare
HeroicEric
changed the title
| @@ -26,6 +26,7 @@ | |||
| "ember-cli-babel": "^7.8.0", | |||
| "ember-cli-path-utils": "^1.0.0", | |||
| "ember-cli-typescript": "^2.0.2", | |||
| "ember-decorators-polyfill": "^1.0.6", | |||
There was a problem hiding this comment.
I think we only need this in our ember-try config, I believe it would be on consuming apps to install the polyfill? Otherwise this lgtm.
cc @rwjblue
There was a problem hiding this comment.
If that is true, then we have to revert #6249 (since it means that [email protected] is not compatible with its own current support policy, and requires that the host app bring the polyfill).
🤔
There was a problem hiding this comment.
@rwjblue I’m more concerned with whether adding the polyfill would troll end consumers that bring their own version.
There was a problem hiding this comment.
I agree with @rwjblue, but lets discuss today
There was a problem hiding this comment.
fwiw it wouldn't mean we need to revert, only that we should change from using @computed to using a getter
|
Replaced by #6331 |
Extracted from #6098
#6249 refactored
Storeto a class. As part of this refactoring,Store#defaultAdapterwas implemented using the@computeddecorator. Using the@computeddecorator requires Ember 3.10+.This adds
ember-decorators-polyfillas a dependency to@ember-data/storeto add support for apps using an Ember version < 3.10.Note: I don't believe this is needed for
releasebecause the conversion ofStoreto a class was reverted