[FEAT] RequestManager (emberjs/rfcs#860) #6642

runspired · 2019-10-25T14:10:13Z

Implements @ember-data/request Package from emberjs/rfcs#860

progress towards finalizing #6166
Required for #8086

TODO

implement RequestManager
implement Fetch handler
add RequestManager tests
update docs and code import paths to reflect named import/export
re-review new READMEs
add API docs
update RFC with implementation notes and final interfaces

TODO (follow up)

add experimental typescript definitions for RequestManager / Handler / Fetch handler
makes store.notifications public to give access to the notification manager
add cache.peek to give access to full resource data (EmberData | Cache v2.1 rfcs#854)
add support for RequestManager to the store
add LegacyHandler

github-actions · 2019-11-06T02:29:21Z

Asset Size Report for 6c24bd1

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '165.42 KB' │
│ compressed │ '35.14 KB'  │
│  packages  │      9      │
│  modules   │     46      │
└────────────┴─────────────┘

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '44.25 KB' │
│  compressed  │ '9.40 KB'  │
│ % Of Library │   '26.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 43.77 KB  | 9.30 KB    | 98.9          | 26.5
	@ember-data/model/index                           | 486.00 B  | 103.23 B   | 1.1           | 0.3

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '42.39 KB' │
│  compressed  │ '9.00 KB'  │
│ % Of Library │   '25.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 41.39 KB  | 8.79 KB    | 97.6          | 25.0
	@ember-data/store/index                           | 1022.00 B | 217.09 B   | 2.4           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.28 KB' │
│  compressed  │ '4.95 KB'  │
│ % Of Library │   '14.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.28 KB  | 4.95 KB    | 100.0         | 14.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.32 KB' │
│  compressed  │ '4.32 KB'  │
│ % Of Library │   '12.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.36 KB   | 1.56 KB    | 36.2          | 4.4
	@ember-data/serializer/-private                   | 5.50 KB   | 1.17 KB    | 27.1          | 3.3
	@ember-data/serializer/json-api                   | 3.79 KB   | 824.40 B   | 18.7          | 2.3
	@ember-data/serializer/rest                       | 2.87 KB   | 623.24 B   | 14.1          | 1.7
	@ember-data/serializer/index                      | 611.00 B  | 129.78 B   | 2.9           | 0.4
	@ember-data/serializer/transform                  | 215.00 B  | 45.67 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.94 KB' │
│  compressed  │ '3.39 KB'  │
│ % Of Library │   '9.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.87 KB   | 1.67 KB    | 49.4          | 4.8
	@ember-data/adapter/-private                      | 3.80 KB   | 825.88 B   | 23.8          | 2.3
	@ember-data/adapter/error                         | 1.82 KB   | 396.37 B   | 11.4          | 1.1
	@ember-data/adapter/index                         | 1.41 KB   | 307.15 B   | 8.9           | 0.9
	@ember-data/adapter/json-api                      | 1.03 KB   | 224.95 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.30 KB' │
│  compressed  │ '1.76 KB' │
│ % Of Library │   '5.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.96 KB   | 427.38 B   | 23.7          | 1.2
	ember-data/-private                               | 1.53 KB   | 333.71 B   | 18.5          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 258.51 B   | 14.3          | 0.7
	ember-data/setup-container                        | 368.00 B  | 78.17 B    | 4.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.54 B    | 3.7           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.20 B    | 3.2           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.31 B    | 3.0           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.04 B    | 2.9           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.61 B    | 2.9           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.61 B    | 2.9           | 0.1
	ember-data/transform                              | 241.00 B  | 51.19 B    | 2.8           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.34 B    | 2.8           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.28 B    | 2.7           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.00 B    | 2.7           | 0.1
	ember-data/model                                  | 222.00 B  | 47.15 B    | 2.6           | 0.1
	ember-data/store                                  | 222.00 B  | 47.15 B    | 2.6           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.30 B    | 2.6           | 0.1
	ember-data/version                                | 162.00 B  | 34.41 B    | 1.9           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.69 KB' │
│  compressed  │ '1.42 KB' │
│ % Of Library │   '4.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.99 KB   | 649.79 B   | 44.7          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 345.60 B   | 23.7          | 1.0
	ember-inflector/lib/system                        | 471.00 B  | 100.04 B   | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 80.50 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 78.38 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 70.52 B    | 4.8           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.54 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 62.87 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '3.02 KB'  │
│  compressed  │ '655.95 B' │
│ % Of Library │   '1.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 494.51 B   | 75.4          | 1.4
	@ember-data/debug/setup                           | 760.00 B  | 161.43 B   | 24.6          | 0.4

Package: @ember-data/tracking
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.24 KB'  │
│  compressed  │ '269.13 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/tracking/-private                     | 839.00 B  | 178.21 B   | 66.2          | 0.5
	@ember-data/tracking/index                        | 428.00 B  | 90.91 B    | 33.8          | 0.3

github-actions · 2020-01-23T23:40:26Z

Performance Report for ba0f238

Relationship Analysis

                        -------------

__/\\\\\\\\\\\\\____/\\\\____________/\\\\____/\\\\\\\\\_____
 _\/\\\/////////\\\_\/\\\\\\________/\\\\\\__/\\\///////\\\___
  _\/\\\_______\/\\\_\/\\\//\\\____/\\\//\\\_\///______\//\\\__
   _\/\\\\\\\\\\\\\/__\/\\\\///\\\/\\\/_\/\\\___________/\\\/___
    _\/\\\/////////____\/\\\__\///\\\/___\/\\\________/\\\//_____
     _\/\\\_____________\/\\\____\///_____\/\\\_____/\\\//________
      _\/\\\_____________\/\\\_____________\/\\\___/\\\/___________
       _\/\\\_____________\/\\\_____________\/\\\__/\\\\\\\\\\\\\\\_
        _\///______________\///______________\///__\///////////////__


                          Runtime Edition

        PM2 is a Production Process Manager for Node.js applications
                     with a built-in Load Balancer.

                Start and Daemonize any application:
                $ pm2 start app.js

                Load Balance 4 instances of api.js:
                $ pm2 start api.js -i 4

                Monitor in production:
                $ pm2 monitor

                Make pm2 auto-boot at server restart:
                $ pm2 startup

                To go further checkout:
                http://pm2.io/


                        -------------

[PM2] Spawning PM2 daemon with pm2_home=/home/runner/.pm2
[PM2] PM2 Successfully daemonized
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name       │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control    │ default     │ N/A     │ fork    │ 3110     │ 0s     │ 0    │ online    │ 0%       │ 69.6mb   │ runner   │ disabled │
└─────┴────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬───────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name          │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼───────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control       │ default     │ N/A     │ fork    │ 3110     │ 0s     │ 0    │ online    │ 0%       │ 69.6mb   │ runner   │ disabled │
│ 1   │ experiment    │ default     │ N/A     │ fork    │ 3134     │ 0s     │ 0    │ online    │ 0%       │ 28.1mb   │ runner   │ disabled │
└─────┴───────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
Computing results...


┌───────────────────────────────────────────────────────────────────────┐
│ Initial Render : duration                                             │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1785ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 2178ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1795ms                 │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 1806ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1819ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1848ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1870ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1786ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 2104ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1808ms                 │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 1822ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1842ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1859ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1877ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 16ms                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ 5ms to 26ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ true                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▃█▃▁▁▁▁▁▁                    │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁█▄▁▁▁▁▁▁                    │
└────────────────────────────────────────┴──────────────────────────────┘


┌───────────────────────────────────────────────────────────────────────┐
│ Sub Phase of Duration : start-find-all                                │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1297ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 1663ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1316ms                 │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 1324ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1333ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1355ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1370ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1309ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 1594ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1323ms                 │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 1330ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1342ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1359ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1371ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 7ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -1ms to 14ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁█▃▁▁▁▁▁▁                    │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁█▃▁▁▁▁▁▁                    │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : start-outer-materialization                   │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 444ms                   │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 546ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 453ms                  │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 459ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 465ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 474ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 481ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 440ms                   │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 565ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 457ms                  │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 465ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 471ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 480ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 493ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 6ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ 2ms to 10ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ true                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁▅█▄▂▁▁▁▁▁▁▁▁                │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁▂█▅▃▂▁▁▁▁▁▁▁                │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : stop-outer-materialization                    │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 0ms                    │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 0ms                    │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 0ms                    │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 0ms                    │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 0ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ 0ms to 0ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ true                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁█▂▁▁▁▁▁▁▁▁▁▁▁▁              │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁█▄▁▁▁▁▁▁▁▁▁▁▁▁              │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : end-find-all                                  │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 20ms                    │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 31ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 20ms                   │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 20ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 20ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 20ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 21ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 19ms                    │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 45ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 20ms                   │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 20ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 20ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 22ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 31ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 0ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ 0ms to 1ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ true                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▃█▁▁▁▁▁▁▁▁▁▁▁▁               │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▂█▂▁▁▁▁▁▁▁▁▁▁▁               │
└────────────────────────────────────────┴──────────────────────────────┘

    =========== Benchmark Results Summary ===========    
Red color means there was a regression. Green color means there was an improvement. You can view more statistical details about the phases above.

duration phase has an estimated difference of +16ms. 

start-find-all phase has no difference. 

start-outer-materialization phase has an estimated difference of +6ms. 

stop-outer-materialization phase has no difference. 

end-find-all phase has an estimated difference of -0ms. 

[PM2] [v] Modules Stopped
[PM2] Applying action deleteProcessId on app [all](ids: [ 0, 1 ])
[PM2] [control](0) ✓
[PM2] [experiment](1) ✓
[PM2] [v] All Applications Stopped
[PM2] [v] PM2 Daemon Stopped
M	yarn.lock

packages/request/README.md

packages/store/README.md

runspired requested a review from igorT October 25, 2019 14:10

runspired force-pushed the feat/request-manager branch from f5de8f2 to 629393b Compare October 25, 2019 14:38

runspired added the 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 label Nov 5, 2019

runspired added 🏷️ feat This PR introduces a new feature 🎯 canary PR is targeting canary (default) labels Nov 5, 2019

runspired force-pushed the feat/request-manager branch from 629393b to a44176e Compare November 6, 2019 02:26

runspired assigned igorT Nov 28, 2019

runspired force-pushed the feat/request-manager branch from a44176e to ba0f238 Compare January 23, 2020 23:31

runspired removed the 🎯 canary PR is targeting canary (default) label Apr 25, 2020

runspired added the 5.0 Roadmap label Aug 9, 2022

runspired force-pushed the feat/request-manager branch 2 times, most recently from c4efbdb to d7b6d01 Compare November 18, 2022 01:13

runspired changed the title ~~[FEAT] (private) request-manager~~ [FEAT] ReqestManager Nov 18, 2022

runspired removed the request for review from igorT November 18, 2022 01:14

runspired unassigned igorT Nov 18, 2022

runspired force-pushed the feat/request-manager branch from 9c02c15 to e213b8f Compare November 19, 2022 00:37

runspired mentioned this pull request Nov 19, 2022

docs: update main overviews #8297

Closed

sly7-7 reviewed Nov 21, 2022

View reviewed changes

packages/request/README.md Show resolved Hide resolved

sly7-7 reviewed Nov 21, 2022

View reviewed changes

packages/store/README.md Outdated Show resolved Hide resolved

runspired changed the title ~~[FEAT] ReqestManager~~ [FEAT] RequestManager (emberjs/rfcs#860) Nov 22, 2022

runspired added ci-assetsize Activates Asset Size Checks in CI 🎯 canary PR is targeting canary (default) labels Nov 23, 2022

runspired added 4 commits November 23, 2022 14:59

feat: request-manager

cfe8129

more docs

976c143

more docs

ad9472c

Add installation instructions

c4f26ce

runspired added 9 commits November 23, 2022 15:03

polish streams support

48570ff

add abort controller support

7d9333c

add Response handling

b24f247

fix lint

5f3b657

more docs

b20e37c

more docs

8d1f5b3

rfc updates

46c7a46

initial spike of new cache types

eee470c

update lockfile

694dccf

runspired force-pushed the feat/request-manager branch from 94c5c1f to 694dccf Compare November 23, 2022 23:04

runspired added 17 commits November 23, 2022 15:10

isolate changes

78d3f1a

isolate more things

fe5d7fd

remove exp types

5a33ed1

udpate imports

4612c93

docs updates

642e9fd

update docs

5faef6f

finish overview

5dc7491

fix lint

ded11ee

fix test

530688f

update lockfile

b78f2f0

skip fix for now

2a92221

fix tests

fcc7bfa

fix unstable test

51b4f02

we dont have prod tests for request manager yet so dont run them in prod

9de1f94

actually fix url

3513c32

nvm

f0ab1fa

fix content-length check

6c24bd1

runspired merged commit 965eb0a into master Nov 24, 2022

delete-merged-branch bot deleted the feat/request-manager branch November 24, 2022 07:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEAT] RequestManager (emberjs/rfcs#860) #6642

[FEAT] RequestManager (emberjs/rfcs#860) #6642

runspired commented Oct 25, 2019 •

edited

Loading

github-actions bot commented Nov 6, 2019 •

edited

Loading

github-actions bot commented Jan 23, 2020

[FEAT] RequestManager (emberjs/rfcs#860) #6642

[FEAT] RequestManager (emberjs/rfcs#860) #6642

Conversation

runspired commented Oct 25, 2019 • edited Loading

github-actions bot commented Nov 6, 2019 • edited Loading

github-actions bot commented Jan 23, 2020

runspired commented Oct 25, 2019 •

edited

Loading

github-actions bot commented Nov 6, 2019 •

edited

Loading