Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation: Model.reopen/reopenClass and eager static fields lookups #8092

Merged
merged 11 commits into from
Jul 30, 2022

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Jul 30, 2022

Implements emberjs/rfcs#738 and emberjs/rfcs#741 in prep for #8086

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality labels Jul 30, 2022
@github-actions
Copy link

github-actions bot commented Jul 30, 2022

Asset Size Report for 4614aa2

Modern Builds

✅ EmberData shrank by -13.0 B (-55.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +178.68 KB -13.0 B (+37.21 KB -55.0 B compressed)
    @ember-data/model +47.18 KB -13.0 B (+9.83 KB -55.0 B compressed)
        @ember-data/model/-private +46.71 KB -13.0 B (+9.73 KB -55.0 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '178.68 KB' │
│ compressed │ '37.21 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '51.95 KB' │
│  compressed  │ '10.82 KB' │
│ % Of Library │   '29.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 50.95 KB  | 10.61 KB   | 98.1          | 28.5
	@ember-data/store/index                           | 1022.00 B | 212.83 B   | 1.9           | 0.6

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '47.18 KB' │
│  compressed  │ '9.83 KB'  │
│ % Of Library │   '26.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 46.71 KB  | 9.73 KB    | 99.0          | 26.1
	@ember-data/model/index                           | 486.00 B  | 101.20 B   | 1.0           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.53 KB' │
│  compressed  │ '5.11 KB'  │
│ % Of Library │   '13.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.53 KB  | 5.11 KB    | 100.0         | 13.7

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.57 KB' │
│  compressed  │ '4.28 KB'  │
│ % Of Library │   '11.5'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.34 KB   | 1.53 KB    | 35.7          | 4.1
	@ember-data/serializer/-private                   | 5.67 KB   | 1.18 KB    | 27.6          | 3.2
	@ember-data/serializer/json-api                   | 3.83 KB   | 816.12 B   | 18.6          | 2.1
	@ember-data/serializer/rest                       | 2.93 KB   | 625.37 B   | 14.3          | 1.6
	@ember-data/serializer/index                      | 611.00 B  | 127.24 B   | 2.9           | 0.3
	@ember-data/serializer/transform                  | 215.00 B  | 44.77 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '16.10 KB' │
│  compressed  │ '3.35 KB'  │
│ % Of Library │   '9.0'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.88 KB   | 1.64 KB    | 48.9          | 4.4
	@ember-data/adapter/-private                      | 3.79 KB   | 807.17 B   | 23.5          | 2.1
	@ember-data/adapter/error                         | 1.99 KB   | 424.62 B   | 12.4          | 1.1
	@ember-data/adapter/index                         | 1.41 KB   | 301.12 B   | 8.8           | 0.8
	@ember-data/adapter/json-api                      | 1.03 KB   | 220.53 B   | 6.4           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.77 KB' │
│  compressed  │ '1.83 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.14 KB   | 456.89 B   | 24.4          | 1.2
	ember-data/-private                               | 1.83 KB   | 389.42 B   | 20.8          | 1.0
	ember-data/adapters/errors                        | 1.19 KB   | 253.43 B   | 13.5          | 0.7
	ember-data/setup-container                        | 368.00 B  | 76.63 B    | 4.1           | 0.2
	ember-data/relationships                          | 318.00 B  | 66.22 B    | 3.5           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 57.06 B    | 3.1           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 52.27 B    | 2.8           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 51.02 B    | 2.7           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 50.60 B    | 2.7           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 50.60 B    | 2.7           | 0.1
	ember-data/transform                              | 241.00 B  | 50.18 B    | 2.7           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 49.35 B    | 2.6           | 0.1
	ember-data/serializer                             | 232.00 B  | 48.31 B    | 2.6           | 0.1
	ember-data/adapter                                | 226.00 B  | 47.06 B    | 2.5           | 0.1
	ember-data/model                                  | 222.00 B  | 46.23 B    | 2.5           | 0.1
	ember-data/store                                  | 222.00 B  | 46.23 B    | 2.5           | 0.1
	ember-data/attr                                   | 218.00 B  | 45.39 B    | 2.4           | 0.1
	ember-data/version                                | 161.00 B  | 33.52 B    | 1.8           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.39 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 631.82 B   | 44.4          | 1.7
	ember-inflector/lib/system/inflections            | 1.59 KB   | 338.82 B   | 23.8          | 0.9
	ember-inflector/lib/system                        | 471.00 B  | 98.08 B    | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 78.92 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 76.84 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 69.13 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 66.22 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 61.64 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.91 KB'  │
│  compressed  │ '620.79 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.42 KB   | 515.62 B   | 83.1          | 1.4
	@ember-data/debug/setup                           | 505.00 B  | 105.16 B   | 16.9          | 0.3

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬──────────┐
│  (index)   │  Values  │
├────────────┼──────────┤
│   bytes    │ '0.00 B' │
│ compressed │ '1.00 B' │
│  packages  │    0     │
│  modules   │    0     │
└────────────┴──────────┘

@github-actions
Copy link

github-actions bot commented Jul 30, 2022

Performance Report for 4614aa2

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-20ms to 11ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-2ms to 5ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-7ms to 2ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-5ms to 2ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-2ms to 3ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-2ms to 23ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-1ms to 9ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-3ms to 7ms]
⚠️ Phase [start-unload-records] => [end-unload-records]
phase estimated regression +3ms [0ms to 5ms] OR +0.85% [0.07% to 1.7%]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-13ms to 9ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-5ms to 3ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-5ms to 4ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-2ms to 3ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 15ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-6ms to 12ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-2ms to 2ms]
⚠️ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated regression +2ms [0ms to 4ms] OR +2.16% [0.31% to 4.06%]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-21ms to 3ms]
✅ Phase [navigationStart] => [start-push-payload]
phase estimated improvement -4ms [-9ms to 0ms] OR -0.96% [-2.28% to -0.02%]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-6ms to 3ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-1ms to 2ms]

@runspired runspired changed the title chore: eliminate reopen/reopenClass usage deprecation: deprecate Model.reopen/reopenClass and eager static fields lookups Jul 30, 2022
@runspired runspired changed the title deprecation: deprecate Model.reopen/reopenClass and eager static fields lookups deprecation: Model.reopen/reopenClass and eager static fields lookups Jul 30, 2022
@runspired runspired merged commit 73a726b into master Jul 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the runspired/kill-reopen branch July 30, 2022 21:58
@runspired runspired added this to the 🔌 Unplug milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality 🏷️ deprecation 🔌 Project Unplug 🔌
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

1 participant