Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify on length when notifying that many-array has changed #9316

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

grayt0r
Copy link

@grayt0r grayt0r commented Apr 2, 2024

Description

Port #8413 to 4.6.

@grayt0r
Copy link
Author

grayt0r commented Apr 2, 2024

Hopefully targeting the release-4-6 branch is the correct approach here, let me know if not.

The original fix didn't come with a test, but I'm more than happy to add one if necessary.

@runspired runspired self-assigned this Apr 2, 2024
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue backport-old-release PR targets a previous non-lts release labels Apr 2, 2024
@runspired runspired merged commit 9a3fe79 into emberjs:release-4-6 Apr 3, 2024
14 of 29 checks passed
@grayt0r
Copy link
Author

grayt0r commented Apr 4, 2024

@runspired would it be possible to get this released? 🙏

@grayt0r
Copy link
Author

grayt0r commented Apr 12, 2024

@runspired apologies for chasing, but this is the final blocker before I can get our app onto a more modern version of ember - please could you release 4.6.5?

@runspired
Copy link
Contributor

@grayt0r its hard to release these older versions (a lot of careful manual steps) so sometimes it takes feeling like I've got a free hour or so 🙈

I should be able to get to this later today. In the meantime, pnpm patch or yarn patching would let you do your upgrade!

@grayt0r
Copy link
Author

grayt0r commented Apr 15, 2024

@runspired thanks for explaining, I didn't mean to assume it was a simple process. I'm currently a bit limited with regards to patching options but realise that's a me problem :)

@runspired
Copy link
Contributor

@grayt0r haven't forgotten about you, going to be doing some releases of 4.6 and 4.12 tomorrow

@grayt0r
Copy link
Author

grayt0r commented May 2, 2024

@runspired awesome, thank you!

@runspired
Copy link
Contributor

published!

@dwickern
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-old-release PR targets a previous non-lts release 🏷️ bug This PR primarily fixes a reported issue
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants