Fix until in deprecation warning ember-data:schema-service-updates (must be 6.0 instead of 5.0)
#9586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkszepp
changed the title
untilin deprecation warning ember-data:schema-service-updates (must until 6.0 instead of 5.0)until in deprecation warning ember-data:schema-service-updates (must until 6.0 instead of 5.0)
mkszepp
changed the title
until in deprecation warning ember-data:schema-service-updates (must until 6.0 instead of 5.0)until in deprecation warning ember-data:schema-service-updates (must be 6.0 instead of 5.0)
runspired
added
🎯 canary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ember-data:schema-service-updatesdeprecation was planned to introduce in 5.4, but we see this depreaction already in 5.3.9 🤔 (thats no problem, because we can move already now away)...In additional the
untilis incorrect (must be 6.0 instead of 5.0)This PR fix only the
until. I'm not sure if this solves also the other bug that depreacation is already visible...