Skip to content

Commit

Permalink
Merge pull request #454 from bertdeblock/update-node-support
Browse files Browse the repository at this point in the history
Drop support for Node < v14 and add support for Node v16 and v18
  • Loading branch information
ef4 authored Oct 5, 2022
2 parents 15fae24 + 692ad1a commit df0c8be
Show file tree
Hide file tree
Showing 3 changed files with 3,439 additions and 3,954 deletions.
32 changes: 4 additions & 28 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: '12.x'
node-version: '14.x'
- name: install dependencies
run: yarn install --frozen-lockfile --ignore-engines
- name: lint
Expand All @@ -34,19 +34,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu', 'windows', 'macOS']
node: ['6', '8', '10', '12', '14']
exclude:
# excludes node 14 on macOS, this is because
# ember-cli (until ~ 3.12) calls
# `fs.writeFileSync('./tmp/.metadata_never_index)` on macOS platforms
# to instruct spotlight to avoid indexing the local tmp folder
# unfortunately, ember-cli does not pass a value for second arg (the
# content to write) and Node 14 added an assertion
#
# TODO: delete this when we have dropped Node 6 and can update
# ember-cli to a version that doesn't do this
- os: 'macOS'
node: '14'
node: ['14', '16', '18']

steps:
- uses: actions/checkout@v1
Expand All @@ -65,19 +53,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu', 'windows']
node: ['12', '14']
exclude:
# excludes node 14 on macOS, this is because
# ember-cli (until ~ 3.12) calls
# `fs.writeFileSync('./tmp/.metadata_never_index)` on macOS platforms
# to instruct spotlight to avoid indexing the local tmp folder
# unfortunately, ember-cli does not pass a value for second arg (the
# content to write) and Node 14 added an assertion
#
# TODO: delete this when we have dropped Node 6 and can update
# ember-cli to a version that doesn't do this
- os: 'macOS'
node: '14'
node: ['14', '16', '18']

steps:
- uses: actions/checkout@v1
Expand All @@ -97,7 +73,7 @@ jobs:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: '12.x'
node-version: '14.x'
- name: install dependencies
run: yarn install --no-lockfile --ignore-engines
- name: test
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"common-tags": "^1.8.0",
"console-ui": "^2.2.2",
"core-object": "^3.1.5",
"ember-cli": "~3.3.0",
"ember-cli": "~3.5.0",
"ember-cli-dependency-checker": "^3.0.0",
"eslint": "^4.0.0",
"ember-cli-htmlbars": "^3.0.0",
Expand All @@ -107,7 +107,7 @@
"resolve": "^1.8.1"
},
"engines": {
"node": "6.* || 8.* || >= 10.*"
"node": "14.* || 16.* || >= 18"
},
"resolutions": {
"**/engine.io": "~3.3.0"
Expand Down
Loading

0 comments on commit df0c8be

Please sign in to comment.