Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test watch-mode and 'software' in uncountable words #500

Closed

Conversation

abhijeetjha0
Copy link

@abhijeetjha0 abhijeetjha0 commented Jun 15, 2024

What is added ?
ember test --server in the package.json file as a pnpm command. We can now run it by executing pnpm run test:watch.

What is fixed ?
'Software' was being pluralized as Softwares whereas it is an uncountable Noun. Fixed that.

@NullVoxPopuli
Copy link
Contributor

any chance you'd be willing to rebase? Sorry I missed this PR!! <3

@abhijeetjha0
Copy link
Author

any chance you'd be willing to rebase? Sorry I missed this PR!! <3

Done ✅ @NullVoxPopuli

Copy link

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of this library is not to offer a definitive set of inflections and irregular/uncountable words but to offer the primitives that an app may use to define these as it so needs.

The existing built-in list of irregular and uncountable words is only there as a very brief reference.

Adding new words like software to the list of uncountable words should be done by the consuming app

@abhijeetjha0
Copy link
Author

The goal of this library is not to offer a definitive set of inflections and irregular/uncountable words but to offer the primitives that an app may use to define these as it so needs.

The existing built-in list of irregular and uncountable words is only there as a very brief reference.

Adding new words like software to the list of uncountable words should be done by the consuming app

Thank you @runspired, I thought it should be added as it is a very common uncountable term widely used in the industry. Should I go ahead and undo the changes then ?

@NullVoxPopuli
Copy link
Contributor

@runspired makes a good point, and we don't really want to change the behaviors of this library, since it could have unexpected consequences (imagine a bug out there where someone is relying on the pluralization of "software")

To add software to ones own app, one could do:

import Inflector from 'ember-inflector';

Inflector.inflector.uncountable('software');

In some place, like app/app.js.

I appreciate your contribution @abhijeetjha0 <3
You forced some good discussion about how we want to handle maintenance for this library.

@abhijeetjha0
Copy link
Author

abhijeetjha0 commented Aug 5, 2024

@runspired makes a good point, and we don't really want to change the behaviors of this library, since it could have unexpected consequences (imagine a bug out there where someone is relying on the pluralization of "software")

To add software to ones own app, one could do:

import Inflector from 'ember-inflector';



Inflector.inflector.uncountable('software');

In some place, like app/app.js.

I appreciate your contribution @abhijeetjha0 <3

You forced some good discussion about how we want to handle maintenance for this library.

Should I reopen this PR with watch mode test command changes only ? It is already in Readme file. @NullVoxPopuli

@NullVoxPopuli
Copy link
Contributor

ah yeah, a fix to our documentation / making the documentation correct would be very welcome.
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants