-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test watch-mode and 'software' in uncountable words #500
Conversation
any chance you'd be willing to rebase? Sorry I missed this PR!! <3 |
7a2a39b
to
8350406
Compare
Done ✅ @NullVoxPopuli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of this library is not to offer a definitive set of inflections and irregular/uncountable words but to offer the primitives that an app may use to define these as it so needs.
The existing built-in list of irregular and uncountable words is only there as a very brief reference.
Adding new words like software
to the list of uncountable words should be done by the consuming app
Thank you @runspired, I thought it should be added as it is a very common uncountable term widely used in the industry. Should I go ahead and undo the changes then ? |
@runspired makes a good point, and we don't really want to change the behaviors of this library, since it could have unexpected consequences (imagine a bug out there where someone is relying on the pluralization of "software") To add import Inflector from 'ember-inflector';
Inflector.inflector.uncountable('software'); In some place, like I appreciate your contribution @abhijeetjha0 <3 |
Should I reopen this PR with watch mode test command changes only ? It is already in Readme file. @NullVoxPopuli |
ah yeah, a fix to our documentation / making the documentation correct would be very welcome. |
What is added ?
ember test --server
in thepackage.json
file as apnpm
command. We can now run it by executingpnpm run test:watch
.What is fixed ?
'Software' was being pluralized as
Softwares
whereas it is an uncountable Noun. Fixed that.