-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support in-element & wormhole #2402
Conversation
782026b
to
f23c584
Compare
a179496
to
ace3935
Compare
1a20b9e
to
35b3576
Compare
@RobbieTheWagner this is ready for review |
35b3576
to
1e3eb9e
Compare
1e3eb9e
to
5d6ce07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems okay to me, I just wonder if there is anything built in to the internals of glimmer or modifiers that could make this easier? @wycats @chancancode @MelSumner @kategengler who is working on things related to this? Would love to get a thumbs up from them that this is the best way to do things.
57daa37
to
b69aa68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though, I'd like to see it tested out first -- got a demo / gif or something of before/after?
Not at the moment, in holidays... |
6588f94
to
d6faf27
Compare
@NullVoxPopuli I am sure this is functionally fine, I just wanted to make sure there wasn't an easier glimmer API we could hook into or something because this all seems very manual. |
d6faf27
to
162d449
Compare
162d449
to
c26427b
Compare
Since there has been no response from stakeholders, I am going to merge this. If there is a better way, we can always update things later. Thanks for the PR @patricklx! |
this injects a InElement component into the component tree, which has its bounds set to the target. it also adds it as a root tree element, so the click & hover work correctly.
This is also done for EmberWormhole, the code checks for the EmberWormhole instance and changes the bounds to its target element
resolves #1255
closes #1375