For ember-source 5.10-beta+, do not use the Ember barrel file (it's been deprecated) #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the only parts that need changes is in ember_debug |
|
But is the boot event 'Ember' still dispatched? It was part of ember/index and inspector depends on it |
|
all of |
|
Is this why canary tests are failing? Wondering what fixes we need there. |
NullVoxPopuli
force-pushed
the
try-not-to-depend-on-the-ember-barrel-file
branch
from
9a4260d
to
b5ac961
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RFC: emberjs/rfcs#1003
Implementation: emberjs/ember.js#20686
Advancement: emberjs/rfcs#1015
Deprecation Guide: ember-learn/deprecation-app#1381
Screenshots