Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable command is destructive in an addon #74

Closed
patocallaghan opened this issue Feb 4, 2019 · 1 comment · Fixed by #159
Closed

Enable command is destructive in an addon #74

patocallaghan opened this issue Feb 4, 2019 · 1 comment · Fixed by #159

Comments

@patocallaghan
Copy link

patocallaghan commented Feb 4, 2019

ember-cli: 3.7.1
node: 10.15.0
os: darwin x64
optional-features addon: 0.7.0
  1. Install addon ember install @ember/optional-features
  2. Enable jquery-integration ember feature:enable jquery-integration
➜  test-addon git:(master) ✗ node_modules/.bin/ember feature:enable jquery-integration
Enabled jquery-integration. Be sure to commit config/optional-features.json to source control!
➜  test-addon git:(master) ✗ cat tests/dummy/config/optional-features.json
{
  "jquery-integration": true
}
  1. Enable another feature e.g. template-only-glimmer-components
➜  test-addon git:(master) ✗ node_modules/.bin/ember feature:enable template-only-glimmer-components
Enabled template-only-glimmer-components. Be sure to commit config/optional-features.json to source control!
➜  test-addon git:(master) ✗ cat tests/dummy/config/optional-features.json
{
  "template-only-glimmer-components": true
}
  1. It should add your newly enabled feature to the list but instead it is destructive. The enable command is destructive and overwrites any previously added features in the addon's dummy app config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants