re-apply blueprint #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Oct 18, 2020
| "release-it": "^12.2.1", | ||
| "release-it-lerna-changelog": "^1.0.3" | ||
| }, | ||
| "engines": { | ||
| "node": "6.* || 8.* || >= 10.*" |
There was a problem hiding this comment.
breaking change
NullVoxPopuli
commented
Oct 18, 2020
|
looks like the modifier manager polyfill broke somehow? |
rwjblue
requested changes
Oct 19, 2020
| - "6" | ||
| - "10" |
There was a problem hiding this comment.
Can you do this (along with the package.json engines update) in a stand alone PR? Specifically to call out the breaking change of dropping old node support...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while working on #25,
I noticed that the linting didn't like decorators (wanted to use @Tracked for adding tests).
I figured the last blueprint applied to this addon was pre-octane, so re-applying ember-cli-update hopefully "just works"?