Update manager capabilities to 3.22 to fix deprecation in Ember 3.26

.github/workflows/ci-build.yml

@@ -20,13 +20,13 @@ jobs:
         with:
           node-version: 10.x
       - name: install dependencies
-        run: yarn install
+        run: npm install
       - name: lint:js
-        run: yarn lint:js
+        run: npm run lint:js
       - name: lint:hbs
-        run: yarn lint:hbs
+        run: npm run lint:hbs
       - name: test
-        run: yarn test
+        run: npm run test
 
   try-scenarios:
     name: ${{ matrix.ember-try-scenario }}
@@ -57,7 +57,7 @@ jobs:
         with:
           node-version: 12.x
       - name: install dependencies
-        run: yarn install
+        run: npm install
       - name: test
         env:
           EMBER_TRY_SCENARIO: ${{ matrix.ember-try-scenario }}

CONTRIBUTING.md

@@ -4,13 +4,13 @@
 
 * `git clone <repository-url>`
 * `cd @ember/render-modifiers`
-* `yarn install`
+* `npm install`
 
 ## Linting
 
-* `yarn lint:hbs`
-* `yarn lint:js`
-* `yarn lint:js --fix`
+* `npm run lint:hbs`
+* `npm run lint:js`
+* `npm run lint:js --fix`
 
 ## Running tests
 
@@ -23,4 +23,4 @@
 * `ember serve`
 * Visit the dummy application at [http://localhost:4200](http://localhost:4200).
 
-For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).
+For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).

RELEASE.md

@@ -37,18 +37,18 @@ Once the prep work is completed, the actual release is straight forward:
 # using https://volta.sh
 volta install release-it
 
-# using Yarn
-yarn global add release-it
+# using npm
+npm i -g release-it
 
 # using npm
-npm install --global release-it
+npm i -g release-it
 ```
 
 * Second, ensure that you have installed your projects dependencies:
 
 ```
-# using yarn
-yarn install
+# using npm
+npm install
 
 # using npm
 npm install

addon/modifiers/did-insert.js

@@ -1,4 +1,5 @@
 import { setModifierManager, capabilities } from '@ember/modifier';
+import { gte } from 'ember-compatibility-helpers';
 
 /**
   The `{{did-insert}}` element modifier is activated when an element is
@@ -46,18 +47,11 @@ import { setModifierManager, capabilities } from '@ember/modifier';
 */
 export default setModifierManager(
   () => ({
-    capabilities: capabilities('3.13', { disableAutoTracking: true }),
+    capabilities: capabilities(gte('3.22.0') ? '3.22' : '3.13', { disableAutoTracking: true }),
 
     createModifier() {},
 
-    installModifier(
-      _state,
-      element,
-      {
-        positional: [fn, ...args],
-        named,
-      }
-    ) {
+    installModifier(_state, element, { positional: [fn, ...args], named }) {
       fn(element, args, named);
     },
 

addon/modifiers/did-update.js

@@ -1,4 +1,5 @@
 import { setModifierManager, capabilities } from '@ember/modifier';
+import { gte } from 'ember-compatibility-helpers';
 
 /**
   The `{{did-update}}` element modifier is activated when any of its arguments
@@ -58,19 +59,38 @@ import { setModifierManager, capabilities } from '@ember/modifier';
 */
 export default setModifierManager(
   () => ({
-    capabilities: capabilities('3.13', { disableAutoTracking: true }),
+    capabilities: gte('3.22.0')
+      ? capabilities('3.22', { disableAutoTracking: false })
+      : capabilities('3.13', { disableAutoTracking: true }),
 
     createModifier() {
       return { element: null };
     },
-    installModifier(state, element) {
+    installModifier(state, element, args) {
       // save element into state bucket
       state.element = element;
+      if (gte('3.22.0')) {
+        // consume all args
+        for (let i = 0; i < args.positional.length; i++) {
+          args.positional[i]; // "noop" / consume the arg
+        }
+        for (let key of Object.keys(args.named)) {
+          args.named[key]; // "noop" / consume the arg
+        }
+      }
     },
 
     updateModifier({ element }, args) {
+      if (gte('3.22.0')) {
+        // consume all args
+        for (let i = 0; i < args.positional.length; i++) {
+          args.positional[i]; // "noop" / consume the arg
+        }
+        for (let key of Object.keys(args.named)) {
+          args.named[key]; // "noop" / consume the arg
+        }
+      }
       let [fn, ...positional] = args.positional;
-
       fn(element, positional, args.named);
     },
 

addon/modifiers/will-destroy.js

@@ -1,4 +1,5 @@
 import { setModifierManager, capabilities } from '@ember/modifier';
+import { gte } from 'ember-compatibility-helpers';
 
 /**
   The `{{will-destroy}}` element modifier is activated immediately before the element
@@ -40,7 +41,7 @@ import { setModifierManager, capabilities } from '@ember/modifier';
 */
 export default setModifierManager(
   () => ({
-    capabilities: capabilities('3.13', { disableAutoTracking: true }),
+    capabilities: capabilities(gte('3.22.0') ? '3.22' : '3.13', { disableAutoTracking: true }),
 
     createModifier() {
       return { element: null };

config/ember-try.js

@@ -9,7 +9,6 @@ module.exports = function() {
     getChannelURL('canary'),
   ]).then(urls => {
     return {
-      useYarn: true,
       scenarios: [
         {
           name: 'ember-lts-2.18',
@@ -95,7 +94,7 @@ module.exports = function() {
             },
           },
         },
-        // The default `.travis.yml` runs this scenario via `yarn test`,
+        // The default `.travis.yml` runs this scenario via `npm run test`,
         // not via `ember try`. It's still included here so that running
         // `ember try:each` manually or from a customized CI config will run it
         // along with all the other scenarios.