Arbitrary arguments to wait cause error

[simonihmig]

Seems since this commit where wait delegates to settled, passing a non-object (e.g. boolean) to wait would cause a Cannot use 'in' operator to search for 'waitForTimers' in true error. Prior to this, this would work (the argument would simply have no effect).

Offending line:

ember-test-helpers/addon-test-support/@ember/test-helpers/settled.js

Line 171 in 9eb3e32

waitForTimers = 'waitForTimers' in options ? options.waitForTimers : true;

Example: https://travis-ci.org/kybishop/ember-popper/jobs/328856339#L547
Caused by: https://github.com/kybishop/ember-popper/blob/5d4457588fd9f30f7a0a2aa34a28e86209ae5978/tests/integration/components/ember-popper/action-test.js#L46

[rwjblue]

Great sleuthing. There is another reported issue around this same sort of thing (though I didn’t know it was related until you tracked down the problem).

The fix here should be to check the arg is an object and not-null before checking for options...