[WIP] refactor(legacy support): use unified component #72
Conversation
simonihmig
force-pushed
the
in-element-refactoring
branch
2 times, most recently
from
8b2ac3b
to
f723f26
Compare
* uses `in-element-polyfill` and `maybe-in-element` AST transforms to allow to use `in-element` with legacy support back to Ember 1.13 (ember-wormhole based) * Cleaned up unnecessary legacy components Closes kybishop#71 BREAKING CHANGE: Support for Ember <1.13 has been dropped!
simonihmig
force-pushed
the
in-element-refactoring
branch
from
f723f26
to
de24494
Compare
| } | ||
| return wait() | ||
| .then(() => triggerEvent(document.querySelector('body'), 'scroll')) | ||
| .then(() => wait()) |
There was a problem hiding this comment.
FYI: this change (wait -> () => wait()) is unrelated to my changes but was required, as the latest ember-test-helpers was causing this error when some argument (here the resolved promise) is passed to wait: https://travis-ci.org/kybishop/ember-popper/jobs/328856339#L547.
Don't know if this should be regarded a regression of ember-test-helpers/wait or not? 🤔 /cc @rwjblue
There was a problem hiding this comment.
Ya, can you report over there so we can dig into it?
There was a problem hiding this comment.
|
@pzuraq any idea about this error? https://travis-ci.org/kybishop/ember-popper/jobs/328857614#L542 Happens only for ember-try scenarios with Ember <= 2.12 🤔 |
|
Something is going wrong with the legacy class transform. I'll see if I can debug sometime soon, swamped at the moment |
|
Closing this as master has diverged too much. Another PR will follow... |
in-element-polyfillandmaybe-in-elementAST transforms to allow to usein-elementwith legacy support back to Ember 1.13 (ember-wormhole based)Closes #71
BREAKING CHANGE:
Support for Ember <1.13 has been dropped!