Ensures CoreOutlet is passed the correct parameters (fixes ember-canary) #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ember-canary requires `template` + `environment` be provided to the view. This seems like a reasonable change, but does require “low level” libraries such as `@ember/test-helpers` to make some changes. (Ember PR emberjs/ember.js#19680)
This was referenced Aug 23, 2021
|
LGTM |
scalvert
approved these changes
Aug 23, 2021
scalvert
changed the title
stefanpenner
added a commit
to embroider-build/embroider
that referenced
this pull request
Aug 23, 2021
description of problem: emberjs/ember.js#19680 (comment) fix in @ember/test-helpers: emberjs/ember-test-helpers#1110
stefanpenner
added a commit
to embroider-build/embroider
that referenced
this pull request
Aug 23, 2021
* [fixes #932] fix ember-canary test scenario description of problem: emberjs/ember.js#19680 (comment) fix in @ember/test-helpers: emberjs/ember-test-helpers#1110 * [fixes ember-canary/ember-beta] migrate ember-cli-template-lint -> ember-template-lint Ember-cli-template-lint is deprecated, and now incompatible with ember 4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-canary requires
template+environmentbe provided to the view. This seems like a reasonable change, but does require “low level” libraries such as@ember/test-helpersto make some changes.(Ember PR emberjs/ember.js#19680)
** note: no additional tests required, as ember-canary scenario is broken prior to this changes... in-other words required tests are already part of the test suite **