-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ApplicationInstance should create container
Based on feedback from @stefanpenner, we moved responsibility for creating the default container from the `Application` to the `ApplicationInstance`. Instead, the instance points back at the application’s registry, using it as the basis for a new container. This commit also adds initial documentation to the application instance.
- Loading branch information
Showing
2 changed files
with
34 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 comment
on commit 434e9cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although maybe i wasn't clear, i believe my advice was for the ApplicationInstance to be initiated via the container, not to do the actually container instantiation.
this._super.apply(this, arguments);