[BUGFIX] Fix 'hasAttribute is not a function' when jQuery is disabled

emberjs · May 30, 2019 · 597810e · 597810e
1 parent 70bcd9f
commit 597810e
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/packages/@ember/-internals/glimmer/tests/integration/event-dispatcher-test.js b/packages/@ember/-internals/glimmer/tests/integration/event-dispatcher-test.js
@@ -555,6 +555,29 @@ if (jQueryDisabled) {
         assert.ok(receivedEvent, 'click event was triggered');
         assert.notOk(receivedEvent.originalEvent, 'event is not a jQuery.Event');
       }
+
+      ['@test native event on text node does not throw on hasAttribute [ISSUE #16730]'](assert) {
+        this.registerComponent('x-foo', {
+          ComponentClass: Component.extend({
+            actions: {
+              someAction() {},
+            },
+          }),
+          template: `<a id="inner" href="#" {{action 'someAction'}}>test</a>`,
+        });
+
+        this.render(`{{x-foo id="outer"}}`);
+
+        let node = this.$('#inner')[0].childNodes[0];
+
+        runTask(() => {
+          let event = document.createEvent('HTMLEvents');
+          event.initEvent('mousemove', true, true);
+          node.dispatchEvent(event);
+        });
+
+        assert.ok(true);
+      }
     }
   );
 } else {

diff --git a/packages/@ember/-internals/views/lib/system/event_dispatcher.js b/packages/@ember/-internals/views/lib/system/event_dispatcher.js
@@ -366,7 +366,10 @@ export default EmberObject.extend({
               } else if (event.cancelBubble === true) {
                 break;
               }
-            } else if (target.hasAttribute('data-ember-action')) {
+            } else if (
+              typeof target.hasAttribute === 'function' &&
+              target.hasAttribute('data-ember-action')
+            ) {
               if (actionHandler(target, event) === false) {
                 break;
               }