Merge pull request #5501 from twokul/super-fix

[BUGFIX release] Makes sure that internal properties do not leak onto created objects.
emberjs · Aug 27, 2014 · 72099aa · 72099aa
2 parents 99af3c0 + ed0f4ee
commit 72099aa
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/packages/ember-runtime/lib/system/core_object.js b/packages/ember-runtime/lib/system/core_object.js
@@ -850,10 +850,7 @@ CoreObject.reopen({
         cache._computedProperties = undefined;
       }
     }
-
-    this._super();
   }
 });
 
-
 export default CoreObject;
diff --git a/packages/ember-runtime/tests/system/object/create_test.js b/packages/ember-runtime/tests/system/object/create_test.js
@@ -337,3 +337,21 @@ test("created objects should not share a guid with their superclass", function()
 
   ok(guidFor(objA) !== guidFor(objB), "two instances do not share a guid");
 });
+
+test("ensure internal properties do not leak", function(){
+  var obj = EmberObject.create({
+    firstName: 'Joe',
+    lastName:  'Black'
+  });
+
+  var expectedProperties = ['firstName', 'lastName'];
+  var actualProperties   = [];
+
+  for (var name in obj) {
+    if (obj.hasOwnProperty(name)) {
+      actualProperties.push(name);
+    }
+  }
+
+  deepEqual(actualProperties, expectedProperties, 'internal properties do not leak');
+});