Merge pull request #13187 from MatrixZ/remove-void-component

[Glimmer2] Remove void element test
emberjs · Mar 31, 2016 · a4bd0e8 · a4bd0e8
2 parents dd58346 + 03a96d4
commit a4bd0e8
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 52 deletions.
diff --git a/packages/ember-glimmer/tests/integration/components/curly-components-test.js b/packages/ember-glimmer/tests/integration/components/curly-components-test.js
@@ -413,6 +413,31 @@ moduleFor('Components test: curly components', class extends RenderingTest {
     assert.equal($span.attr('class'), 'inner');
   }
 
+  ['@test a void element does not have childNodes'](assert) {
+    let fooBarInstance;
+    let FooBarComponent = Component.extend({
+      tagName: 'input',
+      init() {
+        this._super();
+        fooBarInstance = this;
+      }
+    });
+
+    this.registerComponent('foo-bar', { ComponentClass: FooBarComponent, template: '' });
+
+    this.render('{{foo-bar}}');
+
+    this.assertComponentElement(this.firstChild, { tagName: 'input', attrs: { 'class': classes('ember-view') } } );
+
+    assert.strictEqual(fooBarInstance.element.childNodes.length, 0);
+
+    this.runTask(() => this.rerender());
+
+    this.assertComponentElement(this.firstChild, { tagName: 'input', attrs: { 'class': classes('ember-view') } } );
+
+    assert.strictEqual(fooBarInstance.element.childNodes.length, 0);
+  }
+
   ['@test it has the right parentView and childViews'](assert) {
     let fooBarInstance, fooBarBazInstance;
 

diff --git a/packages/ember-htmlbars/tests/integration/void-element-component-test.js b/packages/ember-htmlbars/tests/integration/void-element-component-test.js