Merge pull request #11914 from rwjblue/remove-ember-oneway

[CLEANUP beta] Remove `Ember.oneWay`.
emberjs · Jul 29, 2015 · e5c6490 · e5c6490
2 parents df9fba3 + c650f1d
commit e5c6490
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 98 deletions.
diff --git a/packages/ember-metal/lib/binding.js b/packages/ember-metal/lib/binding.js
@@ -466,21 +466,6 @@ export function bind(obj, to, from) {
   return new Binding(to, from).connect(obj);
 }
 
-/**
-  @method oneWay
-  @for Ember
-  @param {Object} obj The root object of the transform.
-  @param {String} to The path to the 'to' side of the binding.
-    Must be relative to obj.
-  @param {String} from The path to the 'from' side of the binding.
-    Must be relative to obj or a global path.
-  @return {Ember.Binding} binding instance
-  @public
-*/
-export function oneWay(obj, to, from) {
-  return new Binding(to, from).oneWay().connect(obj);
-}
-
 export {
   Binding,
   isGlobalPath

diff --git a/packages/ember-metal/lib/main.js b/packages/ember-metal/lib/main.js
@@ -172,8 +172,7 @@ import {
 import {
   Binding,
   bind,
-  isGlobalPath,
-  oneWay
+  isGlobalPath
 } from 'ember-metal/binding';
 import run from 'ember-metal/run_loop';
 import Libraries from 'ember-metal/libraries';
@@ -309,7 +308,6 @@ Ember.immediateObserver = _immediateObserver;
 Ember.mixin = mixin;
 Ember.Mixin = Mixin;
 
-Ember.oneWay = oneWay;
 Ember.bind = bind;
 Ember.Binding = Binding;
 Ember.isGlobalPath = isGlobalPath;

diff --git a/packages/ember-metal/tests/binding/one_way_test.js b/packages/ember-metal/tests/binding/one_way_test.js
diff --git a/packages/ember-runtime/tests/legacy_1x/system/binding_test.js b/packages/ember-runtime/tests/legacy_1x/system/binding_test.js
@@ -2,7 +2,7 @@ import Ember from 'ember-metal/core';
 import {get} from 'ember-metal/property_get';
 import {set} from 'ember-metal/property_set';
 import run from 'ember-metal/run_loop';
-import {Binding, bind, oneWay} from 'ember-metal/binding';
+import {Binding, bind } from 'ember-metal/binding';
 import {observer as emberObserver} from 'ember-metal/mixin';
 import EmberObject from 'ember-runtime/system/object';
 
@@ -120,41 +120,6 @@ QUnit.test('binding disconnection actually works', function() {
   equal(get(toObject, 'value'), 'start');
 });
 
-// ..........................................................
-// one way binding
-//
-
-QUnit.module('one way binding', {
-
-  setup() {
-    run(function() {
-      fromObject = EmberObject.create({ value: 'start' });
-      toObject = EmberObject.create({ value: 'end' });
-      root = { fromObject: fromObject, toObject: toObject };
-      binding = oneWay(root, 'toObject.value', 'fromObject.value');
-    });
-  },
-  teardown() {
-    run.cancelTimers();
-  }
-});
-
-QUnit.test('fromObject change should propagate after flush', function() {
-  run(function() {
-    set(fromObject, 'value', 'change');
-    equal(get(toObject, 'value'), 'start');
-  });
-  equal(get(toObject, 'value'), 'change');
-});
-
-QUnit.test('toObject change should NOT propagate', function() {
-  run(function() {
-    set(toObject, 'value', 'change');
-    equal(get(fromObject, 'value'), 'start');
-  });
-  equal(get(fromObject, 'value'), 'start');
-});
-
 var first, second, third, binding1, binding2; // global variables
 
 // ..........................................................